Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: src/accessors.h

Issue 1632603002: [api] Default native data property setter to replace the setter if the property is writable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.h
diff --git a/src/accessors.h b/src/accessors.h
index 4c8a0b2b7a9a33b0a75fc5a17c4efc9165728ddf..ba02bf2f7b378a49cd513011190364739bb3db30 100644
--- a/src/accessors.h
+++ b/src/accessors.h
@@ -44,6 +44,12 @@ class AccessorInfo;
V(ScriptIsEmbedderDebugScript) \
V(StringLength)
+#define ACCESSOR_SETTER_LIST(V) \
+ V(ReconfigureToDataProperty) \
+ V(ObservedReconfigureToDataProperty) \
+ V(ArrayLengthSetter) \
+ V(FunctionPrototypeSetter)
+
// Accessors contains all predefined proxy accessors.
class Accessors : public AllStatic {
@@ -53,16 +59,18 @@ class Accessors : public AllStatic {
static void name##Getter( \
v8::Local<v8::Name> name, \
const v8::PropertyCallbackInfo<v8::Value>& info); \
- static void name##Setter( \
- v8::Local<v8::Name> name, \
- v8::Local<v8::Value> value, \
- const v8::PropertyCallbackInfo<void>& info); \
static Handle<AccessorInfo> name##Info( \
Isolate* isolate, \
PropertyAttributes attributes);
ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
#undef ACCESSOR_INFO_DECLARATION
+#define ACCESSOR_SETTER_DECLARATION(name) \
+ static void name(v8::Local<v8::Name> name, v8::Local<v8::Value> value, \
+ const v8::PropertyCallbackInfo<void>& info);
+ ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
+#undef ACCESSOR_SETTER_DECLARATION
+
enum DescriptorId {
#define ACCESSOR_INFO_DECLARATION(name) \
k##name##Getter, \
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698