src/lookup.h - Issue 1632603002: [api] Default native data property setter to replace the setter if the property is writable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.h

Issue 1632603002: [api] Default native data property setter to replace the setter if the property is writable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.h

diff --git a/src/lookup.h b/src/lookup.h

index 7d689560b8f7efa5d106d1018fd42c26faa3e9cb..ed713c057c957165e498eccb525170f00792c934 100644

--- a/src/lookup.h

+++ b/src/lookup.h

@@ -237,6 +237,9 @@ class LookupIterator final BASE_EMBEDDED {

DCHECK(has_property_);

return property_details_;

}

+ PropertyAttributes property_attributes() const {

+ return property_details().attributes();

+ }

bool IsConfigurable() const { return property_details().IsConfigurable(); }

bool IsReadOnly() const { return property_details().IsReadOnly(); }

Representation representation() const {

« no previous file with comments | « src/flag-definitions.h ('k') | src/objects.cc » ('j') | no next file with comments »