Store DisplayLauout separately from DisplayInfo in display_options.js

Store DisplayLauout separately from DisplayInfo in display_options.js

Additional cleanup to display_options.js in preparation for 3+ display
support.

BUG=576375
Committed: https://crrev.com/a4e424d15714787ea46fda658b5c9a5b36155de1
Cr-Commit-Position: refs/heads/master@{#371125}

[stevenjb, 2016-01-22 01:26:20]

stevenjb@chromium.org changed reviewers:
+ xiyuan@chromium.org

[stevenjb, 2016-01-22 01:26:20]

More JS cleanup for 3+ display support. This is intended to:
a) Reduce our assumptions of only 2 displays (primary and secondary)
b) Extract the DisplayLayout object used in the JS code from the DisplayInfo
object provided by Chrome. The DisplayLayout object contains just the info
required for resolving display layout (which will soon be moving to a separate
file and will drastically increase in complexity for 3+ monitors).

Thanks for doing these reviews!

[xiyuan, 2016-01-22 16:46:07]

lgtm

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_options.js (right):

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:188: * @type
{!Object<!options.DisplayLayout>}
Do we need to doc the key type as well?

e.g.
  @type {!Object<string, !options.DisplayLayout>}

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:930:
div.classList.add('displays-focused');
nit: div.classList.toggle('displays-focused', displayLayout.id ==
this.focusedId_);

[stevenjb, 2016-01-22 18:48:44]

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_options.js (right):

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:188: * @type
{!Object<!options.DisplayLayout>}
On 2016/01/22 16:46:06, xiyuan wrote:
> Do we need to doc the key type as well?
> 
> e.g.
>   @type {!Object<string, !options.DisplayLayout>}

Object keys are actually always strings (even when we pretend otherwise), so we
don't generally document that, although we can.

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:930:
div.classList.add('displays-focused');
On 2016/01/22 16:46:07, xiyuan wrote:
> nit: div.classList.toggle('displays-focused', displayLayout.id ==
> this.focusedId_);

Done.

[stevenjb, 2016-01-22 18:51:35]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 18:52:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612083004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612083004/100001

[xiyuan, 2016-01-22 18:55:28]

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_options.js (right):

https://codereview.chromium.org/1612083004/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_options.js:188: * @type
{!Object<!options.DisplayLayout>}
I see. Thanks for the clarification.

[commit-bot: I haz the power, 2016-01-22 20:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 20:40:04]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-01-23 01:46:21]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-01-23 01:46:21]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1612083004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-23 01:47:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1612083004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1612083004/100001

[commit-bot: I haz the power, 2016-01-23 01:55:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-23 01:57:03]

Description was changed from

==========
Store DisplayLauout separately from DisplayInfo in display_options.js

Additional cleanup to display_options.js in preparation for 3+ display
support.

BUG=576375
==========

to

==========
Store DisplayLauout separately from DisplayInfo in display_options.js

Additional cleanup to display_options.js in preparation for 3+ display
support.

BUG=576375

Committed: https://crrev.com/a4e424d15714787ea46fda658b5c9a5b36155de1
Cr-Commit-Position: refs/heads/master@{#371125}
==========

[commit-bot: I haz the power, 2016-01-23 01:57:04]

Patchset 6 (id:??) landed as
https://crrev.com/a4e424d15714787ea46fda658b5c9a5b36155de1
Cr-Commit-Position: refs/heads/master@{#371125}