Issue 163183005: Revert 251090 "Revert 250823 "With --site-per-process, avoid a c..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163183005: Revert 251090 "Revert 250823 "With --site-per-process, avoid a c..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)

Modified:
6 years, 10 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 251090 "Revert 250823 "With --site-per-process, avoid a c..." Relanding, this wasn't the cause of the failures. > Revert 250823 "With --site-per-process, avoid a crash when a sub..." > > Speculative revert to see if the navigation changes here are causing > sync_integration_tests to fail on: > > http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11217 > > > With --site-per-process, avoid a crash when a subframe process goes away. > > > > We need to clear out the children of any nodes that are affected by the > > crash, not the entire FrameTree. > > > > BUG=338508 > > TEST=Killing an iframe process with --site-per-process shows a green rectangle. > > R=ajwong@chromium.org, nasko@chromium.org > > > > Review URL: https://codereview.chromium.org/156303004 > > TBR=creis@chromium.org > > Review URL: https://codereview.chromium.org/163703004 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251110

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -11 lines)			Patch
M	trunk/src/content/browser/frame_host/frame_tree.h	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/frame_host/frame_tree.cc	View	2 chunks	+20 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/frame_host/frame_tree_node.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/content/browser/frame_host/frame_tree_node.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/site_per_process_browsertest.cc	View	1 chunk	+62 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Alexei Svitkine (slow)

6 years, 10 months ago (2014-02-13 20:20:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251110.