Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: trunk/src/content/browser/frame_host/frame_tree.h

Issue 163183005: Revert 251090 "Revert 250823 "With --site-per-process, avoid a c..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/browser/frame_host/frame_tree.h
===================================================================
--- trunk/src/content/browser/frame_host/frame_tree.h (revision 251109)
+++ trunk/src/content/browser/frame_host/frame_tree.h (working copy)
@@ -60,7 +60,9 @@
// Executes |on_node| on each node in the frame tree. If |on_node| returns
// false, terminates the iteration immediately. Returning false is useful
- // if |on_node| is just doing a search over the tree.
+ // if |on_node| is just doing a search over the tree. The iteration proceeds
+ // top-down and visits a node before adding its children to the queue, making
+ // it safe to remove children during the callback.
void ForEach(const base::Callback<bool(FrameTreeNode*)>& on_node) const;
// After the FrameTree is created, or after SwapMainFrame() has been called,
@@ -92,6 +94,13 @@
// TODO(creis): Look into how we can remove the need for this method.
void ResetForMainFrameSwap();
+ // Update the frame tree after a process exits. Any nodes currently using the
+ // given |render_view_host| will lose all their children.
+ // TODO(creis): This should take a RenderProcessHost once RenderFrameHost
+ // knows its process. Until then, we would just be asking the RenderViewHost
+ // for its process, so we'll skip that step.
+ void RenderProcessGone(RenderViewHost* render_view_host);
+
// Convenience accessor for the main frame's RenderFrameHostImpl.
RenderFrameHostImpl* GetMainFrame() const;
« no previous file with comments | « no previous file | trunk/src/content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698