Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1631333003: bindings: Throw exceptions when required dictionary members aren't passed (Closed)

Created:
4 years, 11 months ago by bashi
Modified:
4 years, 11 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Throw exceptions when required dictionary members aren't passed Before this CL, we don't check required member field when 'null' is passed as a dictionary. Add the checks. BUG=580531 Committed: https://crrev.com/28e4d5f7391dc6b988a0cf380995301c2b5c1a5c Cr-Commit-Position: refs/heads/master@{#371743}

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 14 (6 generated)
bashi
PTAL?
4 years, 11 months ago (2016-01-27 04:15:59 UTC) #2
haraken
LGTM
4 years, 11 months ago (2016-01-27 04:22:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631333003/20001
4 years, 11 months ago (2016-01-27 04:44:36 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
4 years, 11 months ago (2016-01-27 04:52:11 UTC) #7
Yuki
lgtm
4 years, 11 months ago (2016-01-27 05:33:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631333003/20001
4 years, 11 months ago (2016-01-27 05:38:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 05:43:44 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 05:44:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28e4d5f7391dc6b988a0cf380995301c2b5c1a5c
Cr-Commit-Position: refs/heads/master@{#371743}

Powered by Google App Engine
This is Rietveld 408576698