third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp - Issue 1631333003: bindings: Throw exceptions when required dictionary members aren't passed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

Issue 1631333003: bindings: Throw exceptions when required dictionary members aren't passed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_dictionary.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

index c66a61b885da50ff3e57047b1c87a8b6d6d90e44..459bec61f4f9139d58d46422bc03e01d3f6b3b84 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

@@ -11,8 +11,12 @@ namespace blink {

{% from 'utilities.cpp' import v8_value_to_local_cpp_value %}

void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{cpp_class}}& impl, ExceptionState& exceptionState)

{

- if (isUndefinedOrNull(v8Value))

+ if (isUndefinedOrNull(v8Value)) {

+ {% if required_member_names %}

+ exceptionState.throwTypeError("Missing required member(s): {{required_member_names|join(', ')}}.");

+ {% endif %}

return;

+ }

if (!v8Value->IsObject()) {

{% if use_permissive_dictionary_conversion %}

// Do nothing.