third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp - Issue 1631333003: bindings: Throw exceptions when required dictionary members aren't passed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 1631333003: bindings: Throw exceptions when required dictionary members aren't passed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

index ac6fab3c27eaf60b9c521636e2321a13d3507509..45e8fe1e6e0a6b84e66e8fe1441dea23e39eb3be 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

@@ -12,8 +12,9 @@ namespace blink {

void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, TestPermissiveDictionary& impl, ExceptionState& exceptionState)

{

- if (isUndefinedOrNull(v8Value))

+ if (isUndefinedOrNull(v8Value)) {

return;

+ }

if (!v8Value->IsObject()) {

// Do nothing.

return;

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp ('k') | no next file » | no next file with comments »