Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1631223003: [DevTools] Do not use OverridesSupport anywhere. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not use OverridesSupport anywhere. Split Geolocation and DeviceOrientation off of OverridesSupport, used them in SensorsView. Migrated some tests, DeviceSettingsTab and EmulatedDevices to DeviceModeModel. BUG=540864 Committed: https://crrev.com/99267833bf5544a510af2b11231513ab1d7cc65e Cr-Commit-Position: refs/heads/master@{#371883}

Patch Set 1 #

Total comments: 3

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-26 18:31:51 UTC) #2
pfeldman
https://codereview.chromium.org/1631223003/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js (right): https://codereview.chromium.org/1631223003/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js#newcode11 third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js:11: WebInspector.DeviceOrientation = function(alpha, beta, gamma) Should this be a ...
4 years, 11 months ago (2016-01-27 17:53:18 UTC) #3
pfeldman
lgtm
4 years, 11 months ago (2016-01-27 18:10:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631223003/1
4 years, 11 months ago (2016-01-27 18:17:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 21:55:46 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 21:56:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99267833bf5544a510af2b11231513ab1d7cc65e
Cr-Commit-Position: refs/heads/master@{#371883}

Powered by Google App Engine
This is Rietveld 408576698