Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

Issue 1631223003: [DevTools] Do not use OverridesSupport anywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js b/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
index db062287a7a0d8a00d029ad6c61de3c9fb095d0f..7af5a72c22b113bfd352304814e56cd552798754 100644
--- a/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
+++ b/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js
@@ -119,11 +119,11 @@ WebInspector.EmulatedDevice.fromJSONV1 = function(json)
var result = {};
result.width = parseIntValue(json, "width");
- if (result.width < 0 || result.width > WebInspector.OverridesSupport.MaxDeviceSize)
+ if (result.width < 0 || result.width > WebInspector.DeviceModeModel.MaxDeviceSize || result.width < WebInspector.DeviceModeModel.MinDeviceSize)
throw new Error("Emulated device has wrong width: " + result.width);
result.height = parseIntValue(json, "height");
- if (result.height < 0 || result.height > WebInspector.OverridesSupport.MaxDeviceSize)
+ if (result.height < 0 || result.height > WebInspector.DeviceModeModel.MaxDeviceSize || result.height < WebInspector.DeviceModeModel.MinDeviceSize)
throw new Error("Emulated device has wrong height: " + result.height);
var outlineInsets = parseValue(json["outline"], "insets", "object", null);

Powered by Google App Engine
This is Rietveld 408576698