third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html - Issue 1631223003: [DevTools] Do not use OverridesSupport anywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

Issue 1631223003: [DevTools] Do not use OverridesSupport anywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/devtools.gypi » ('j') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

index 1a55f4a16864a41d393c95f15c501eca3b334e0f..8393d89a0911f31f5e8db00931aa8c719ed399ba 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

@@ -48,8 +48,7 @@ function test()

var originalUserAgent = navigator.userAgent;

InspectorTest.addResult("Enable emulation and set User-Agent override");

- WebInspector.overridesSupport.setEmulationEnabled(true);

- WebInspector.overridesSupport.settings.userAgent.set(userAgentString);

+ WebInspector.multitargetNetworkManager.setUserAgentOverride(userAgentString);

InspectorTest.registerServiceWorker(scriptURL, scope)

.then(waitForTarget)

@@ -58,7 +57,7 @@ function test()

.then(function(msg) {

InspectorTest.addResult("Overriden user agent: " + msg.messageText);

InspectorTest.addResult("Disable emulation");

- WebInspector.overridesSupport.setEmulationEnabled(false);

+ WebInspector.multitargetNetworkManager.setUserAgentOverride("");

return InspectorTest.unregisterServiceWorker(scope);

})

.then(function() {