Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1631063002: Add isPageVisible to Page (Closed)

Created:
4 years, 11 months ago by ortuno
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, dcheng, Eric Willigers, mlamouri+watch-blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org, mvanouwerkerk+watch_chromium.org, rjwright, shans, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add isPageVisible to Page BUG=581172 Committed: https://crrev.com/b1a42b49ed0ad2854637fa8cc25bc8f4fba716e4 Cr-Commit-Position: refs/heads/master@{#371437}

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 5

Patch Set 3 : Remove unnecessary variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ortuno
haraken: per your suggestion I added a new isPageVisible method and replaced all instances of ...
4 years, 11 months ago (2016-01-25 22:50:29 UTC) #2
haraken
Nice clean-up. LGTM. https://codereview.chromium.org/1631063002/diff/20001/third_party/WebKit/Source/core/page/Page.cpp File third_party/WebKit/Source/core/page/Page.cpp (right): https://codereview.chromium.org/1631063002/diff/20001/third_party/WebKit/Source/core/page/Page.cpp#newcode384 third_party/WebKit/Source/core/page/Page.cpp:384: bool Page::isPageVisible() const const won't be ...
4 years, 11 months ago (2016-01-25 22:54:32 UTC) #3
ortuno
https://codereview.chromium.org/1631063002/diff/20001/third_party/WebKit/Source/core/page/Page.cpp File third_party/WebKit/Source/core/page/Page.cpp (right): https://codereview.chromium.org/1631063002/diff/20001/third_party/WebKit/Source/core/page/Page.cpp#newcode384 third_party/WebKit/Source/core/page/Page.cpp:384: bool Page::isPageVisible() const On 2016/01/25 at 22:54:31, haraken wrote: ...
4 years, 11 months ago (2016-01-25 23:36:34 UTC) #4
haraken
https://codereview.chromium.org/1631063002/diff/20001/third_party/WebKit/Source/core/page/Page.cpp File third_party/WebKit/Source/core/page/Page.cpp (right): https://codereview.chromium.org/1631063002/diff/20001/third_party/WebKit/Source/core/page/Page.cpp#newcode384 third_party/WebKit/Source/core/page/Page.cpp:384: bool Page::isPageVisible() const On 2016/01/25 23:36:34, ortuno wrote: > ...
4 years, 11 months ago (2016-01-25 23:40:17 UTC) #5
ortuno
thanks!
4 years, 11 months ago (2016-01-25 23:40:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631063002/40001
4 years, 11 months ago (2016-01-25 23:43:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 03:36:52 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 03:37:44 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b1a42b49ed0ad2854637fa8cc25bc8f4fba716e4
Cr-Commit-Position: refs/heads/master@{#371437}

Powered by Google App Engine
This is Rietveld 408576698