third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp - Issue 1631063002: Add isPageVisible to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

Issue 1631063002: Add isPageVisible to Page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Remove unnecessary variable Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

diff --git a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

index a3201a1f5668054548662ee31b290005ddb607df..357b4ed1c271e6761bff94ab0cde1f49ab4671db 100644

--- a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

+++ b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

@@ -145,7 +145,7 @@ void NavigatorVibration::timerStopFired(Timer<NavigatorVibration>* timer)

void NavigatorVibration::pageVisibilityChanged()

{

- if (page()->visibilityState() != PageVisibilityStateVisible)

+ if (!page()->isPageVisible())

cancelVibration();

}

@@ -176,7 +176,7 @@ bool NavigatorVibration::vibrate(Navigator& navigator, const VibrationPattern& p

if (!page)

return false;

- if (page->visibilityState() != PageVisibilityStateVisible)

+ if (!page->isPageVisible())

return false;

return NavigatorVibration::from(*page).vibrate(pattern);