third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 1631063002: Add isPageVisible to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 1631063002: Add isPageVisible to Page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Remove unnecessary variable Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp ('k') | third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

index 52457c226b45a0da8dbed307dd9a8a86d55a01d4..8e3c8624cf8f2ca630895aeb18f1751132880b92 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -106,7 +106,7 @@ void ScreenOrientationController::updateOrientation()

bool ScreenOrientationController::isActiveAndVisible() const

{

- return m_orientation && frame() && page() && page()->visibilityState() == PageVisibilityStateVisible;

+ return m_orientation && frame() && page() && page()->isPageVisible();

}

void ScreenOrientationController::pageVisibilityChanged()

@@ -230,7 +230,7 @@ void ScreenOrientationController::willDetachFrameHost()

void ScreenOrientationController::notifyDispatcher()

{

- if (m_orientation && page()->visibilityState() == PageVisibilityStateVisible)

+ if (m_orientation && page()->isPageVisible())

startUpdating();

else

stopUpdating();