chrome/common/BUILD.gn - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: merge up to r379824 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index c156b3ae12d19e0e6149417e72cf5d352c11fa95..bb0fbc262d322aaa9bd5d3a4c4849a9041a19258 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -302,6 +302,8 @@ static_library("constants") {

sources = [

"chrome_constants.cc",

"chrome_constants.h",

+ "chrome_constants_util_win.cc",

+ "chrome_constants_util_win.h",

"chrome_features.cc",

"chrome_features.h",

"chrome_icon_resources_win.cc",

@@ -349,6 +351,8 @@ static_library("constants") {

# on this target. On that platform one of the Chrome paths forwards to one

# implemented in //ui/base, so we need that dependency.

deps += [ "//ui/base" ]

+ } else if (is_win) {

+ deps += [ ":installer_util" ]

grt (UTC plus 2) 2016/03/08 15:44:47 circular dependency: is this okay?

}

« chrome/app/main_dll_loader_win.cc ('K') | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/common/chrome_constants.h » ('j') | chrome/common_constants.gyp » ('J')