Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//chrome/common/features.gni")
 import("//chrome/version.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//tools/grit/grit_rule.gni")
 
@@ skipping 284 matching lines @@
   template_file = "chrome_version.h.in"
 
   output = "$target_gen_dir/chrome_version.h"
 }
 
 # GYP version: chrome/common_constants.gyp:common_constants
 static_library("constants") {
   sources = [
     "chrome_constants.cc",
     "chrome_constants.h",
+    "chrome_constants_util_win.cc",
+    "chrome_constants_util_win.h",
     "chrome_features.cc",
     "chrome_features.h",
     "chrome_icon_resources_win.cc",
     "chrome_icon_resources_win.h",
     "chrome_paths.cc",
     "chrome_paths.h",
     "chrome_paths_android.cc",
     "chrome_paths_internal.h",
     "chrome_paths_linux.cc",
     "chrome_paths_mac.mm",
@@ skipping 27 matching lines @@
     #
     # On Windows, //chrome/installer/util depends on this target to get
     # constants. That target is in turn used in a number of installer helper
     # targets independent of Chrome that we want to keep small. So we don't
     # want something large like //ui/base.
     #
     # Android doesn't have this structure and corresponding size limitation
     # on this target. On that platform one of the Chrome paths forwards to one
     # implemented in //ui/base, so we need that dependency.
     deps += [ "//ui/base" ]
+  } else if (is_win) {
+    deps += [ ":installer_util" ]

[grt (UTC plus 2), 2016/03/08 15:44:47]

circular dependency: is this okay?

   }
 }
 
 source_set("test_support") {
   testonly = true
   visibility = [ "//chrome/test:test_support" ]
 
   sources = []
 
   deps = [
@@ skipping 34 matching lines @@
     ":constants",
     "//base",
   ]
 }
 
 mojom("mojo_bindings") {
   sources = [
     "resource_usage_reporter.mojom",
   ]
 }