Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: chrome/common_constants.gyp

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter
Patch Set: merge up to r379824 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common_constants.gyp
diff --git a/chrome/common_constants.gyp b/chrome/common_constants.gyp
index cf315ca0c885143f653197c7e30a08c970617603..ec38879fc45e7185aee999a53cbce136b1b17272 100644
--- a/chrome/common_constants.gyp
+++ b/chrome/common_constants.gyp
@@ -8,6 +8,8 @@
'common_constants_sources': [
'common/chrome_constants.cc',
'common/chrome_constants.h',
+ 'common/chrome_constants_util_win.cc',
+ 'common/chrome_constants_util_win.h',
'common/chrome_features.cc',
'common/chrome_features.h',
'common/chrome_icon_resources_win.cc',
@@ -96,6 +98,11 @@
'sources/': [
['include', '^common/chrome_paths_mac\\.mm$'],
],
+ },
+ 'OS=="win"', {
+ 'dependencies': [
+ 'installer_util',
grt (UTC plus 2) 2016/03/08 15:44:47 you'll minimally need a win-specific includes sect
+ ],
}],
],
'conditions': [
@@ -121,6 +128,7 @@
'<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc.
],
'dependencies': [
+ 'installer_util',
'version_header',
'chrome_features.gyp:chrome_common_features',
'../base/base.gyp:base_win64',

Powered by Google App Engine
This is Rietveld 408576698