Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 1630823006: Ensure arrow functions can close over lexically-scoped variables (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure arrow functions can close over lexically-scoped variables ParseArrowFunctionLiteral was erroneously checking AllowsLazyCompilation rather than AllowsLazyParsing when deciding whether to parse lazily. This meant that lexically-scoped variables that had no other referents wouldn't get closed over properly. BUG=chromium:580934, v8:4255 LOG=y Committed: https://crrev.com/953bb416a3675a4bd899e01625b8b584480e488a Cr-Commit-Position: refs/heads/master@{#33530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/parsing/parser-base.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-580934.js View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
This check seems to have been missed when Yang fixed block scoping in https://codereview.chromium.org/1216013002
4 years, 11 months ago (2016-01-26 22:45:41 UTC) #3
rossberg
lgtm
4 years, 11 months ago (2016-01-26 22:55:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1630823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1630823006/1
4 years, 11 months ago (2016-01-26 22:58:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 23:10:28 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 23:11:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/953bb416a3675a4bd899e01625b8b584480e488a
Cr-Commit-Position: refs/heads/master@{#33530}

Powered by Google App Engine
This is Rietveld 408576698