Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 1216013002: Parse eagerly inside block scopes. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parse eagerly inside block scopes. Only this way we can precisely determine how to allocate let variables inside the scope. R=rossberg@chromium.org BUG=v8:4255 LOG=N Committed: https://crrev.com/972beef14ce917512399d3652c9456f013779438 Cr-Commit-Position: refs/heads/master@{#29354}

Patch Set 1 #

Patch Set 2 : one more test case #

Patch Set 3 : speed up test slightly #

Patch Set 4 : correct fix #

Patch Set 5 : small optimization #

Patch Set 6 : simplified a lot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -11 lines) Patch
M src/parser.cc View 1 2 3 4 5 2 chunks +3 lines, -8 lines 0 comments Download
M src/preparser.h View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M src/scopes.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/scopes.cc View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4255-1.js View 1 chunk +26 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4255-2.js View 1 chunk +24 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4255-3.js View 1 chunk +24 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4255-4.js View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
5 years, 5 months ago (2015-06-29 10:28:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216013002/40001
5 years, 5 months ago (2015-06-29 11:05:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7082)
5 years, 5 months ago (2015-06-29 11:52:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216013002/100001
5 years, 5 months ago (2015-06-29 13:46:33 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-29 14:13:46 UTC) #9
rossberg
lgtm
5 years, 5 months ago (2015-06-29 15:55:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216013002/100001
5 years, 5 months ago (2015-06-29 16:14:39 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 5 months ago (2015-06-29 16:16:10 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 16:16:31 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/972beef14ce917512399d3652c9456f013779438
Cr-Commit-Position: refs/heads/master@{#29354}

Powered by Google App Engine
This is Rietveld 408576698