src/parsing/parser-base.h - Issue 1630823006: Ensure arrow functions can close over lexically-scoped variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser-base.h

Issue 1630823006: Ensure arrow functions can close over lexically-scoped variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parsing/parser-base.h

diff --git a/src/parsing/parser-base.h b/src/parsing/parser-base.h

index bd9ef707b6c694b15c6561dcb63b91554e7822e7..e4947f208a2fa631dae8d5202ebd722ad8486d86 100644

--- a/src/parsing/parser-base.h

+++ b/src/parsing/parser-base.h

@@ -3027,7 +3027,7 @@ ParserBase<Traits>::ParseArrowFunctionLiteral(

// Multiple statement body

Consume(Token::LBRACE);

bool is_lazily_parsed =

- (mode() == PARSE_LAZILY && scope_->AllowsLazyCompilation());

+ (mode() == PARSE_LAZILY && scope_->AllowsLazyParsing());

if (is_lazily_parsed) {

body = this->NewStatementList(0, zone());

this->SkipLazyFunctionBody(&materialized_literal_count,

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-580934.js » ('j') | no next file with comments »