Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163023002: Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily. (Closed)

Created:
6 years, 10 months ago by Junichi Uekawa
Modified:
6 years, 10 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251322

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : fix compile #

Patch Set 4 : rebase #

Patch Set 5 : re-upload #

Patch Set 6 : fix unit test compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chromeos/ime/composition_text.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chromeos/ime/composition_text_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 2 3 4 5 16 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Junichi Uekawa
6 years, 10 months ago (2014-02-14 02:20:29 UTC) #1
Seigo Nonaka
lgtm
6 years, 10 months ago (2014-02-14 02:28:06 UTC) #2
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-14 02:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/163023002/290001
6 years, 10 months ago (2014-02-14 02:30:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 03:39:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-14 03:39:41 UTC) #6
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-14 06:37:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/163023002/600001
6 years, 10 months ago (2014-02-14 06:38:13 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 09:41:46 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202127
6 years, 10 months ago (2014-02-14 09:41:47 UTC) #10
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-14 11:50:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/163023002/600001
6 years, 10 months ago (2014-02-14 11:51:16 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:09:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 251322

Powered by Google App Engine
This is Rietveld 408576698