chrome/browser/chromeos/input_method/input_method_engine.cc - Issue 163023002: Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 163023002: Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit test compile Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/input_method_engine.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc

index e2d0c2cfe8d3a3cdc48c55524a25e98e136c5327..9dd8c71fd6a45e76c1943b1ea77b818aef2e43f7 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc

@@ -144,7 +144,7 @@ bool InputMethodEngine::SetComposition(

composition_cursor_ = cursor;

composition_text_.reset(new CompositionText());

- composition_text_->set_text(text);

+ composition_text_->set_text(base::UTF8ToUTF16(text));

composition_text_->set_selection_start(selection_start);

composition_text_->set_selection_end(selection_end);

« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc » ('j') | no next file with comments »