chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc - Issue 163023002: Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 163023002: Use base::string16 for CompositionText.Text instead of converting to utf-8 and back unnecessarily. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit test compile Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

index d3912f9f62819ec6092e19e25ac6774f59933397..4d199db1c142b0c69092f585895d1b7a91f71d86 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

@@ -470,7 +470,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineIBusBrowserTest,

const CompositionText& composition_text =

mock_input_context->last_update_composition_arg().composition_text;

- EXPECT_EQ("COMPOSITION_TEXT", composition_text.text());

+ EXPECT_EQ(base::UTF8ToUTF16("COMPOSITION_TEXT"), composition_text.text());

const std::vector<CompositionText::UnderlineAttribute>& underlines =

composition_text.underline_attributes();

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chromeos/ime/composition_text.h » ('j') | no next file with comments »