Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 162723003: Migrate CandidateWindow::Entry to string16. (Closed)

Created:
6 years, 10 months ago by Junichi Uekawa
Modified:
6 years, 10 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Migrate CandidateWindow::Entry to string16. BUG=329604 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251032

Patch Set 1 #

Patch Set 2 : fix compile #

Patch Set 3 : ;; #

Patch Set 4 : fix browsertest compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -98 lines) Patch
M ash/ime/candidate_view.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M ash/ime/candidate_window_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/candidate_window_view.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ash/ime/candidate_window_view_unittest.cc View 6 chunks +39 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 2 3 2 chunks +23 lines, -14 lines 0 comments Download
M ui/base/ime/candidate_window.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/ime/candidate_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/candidate_window_unittest.cc View 1 7 chunks +18 lines, -13 lines 0 comments Download
M ui/base/ime/chromeos/ime_bridge.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_candidate_window_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_candidate_window_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Junichi Uekawa
6 years, 10 months ago (2014-02-13 05:51:00 UTC) #1
Seigo Nonaka
lgtm
6 years, 10 months ago (2014-02-13 05:58:01 UTC) #2
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-13 06:31:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/162723003/110001
6 years, 10 months ago (2014-02-13 06:31:50 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:51:08 UTC) #5
Message was sent while issue was closed.
Change committed as 251032

Powered by Google App Engine
This is Rietveld 408576698