Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: ui/base/ime/candidate_window_unittest.cc

Issue 162723003: Migrate CandidateWindow::Entry to string16. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix browsertest compilation Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/candidate_window.cc ('k') | ui/base/ime/chromeos/ime_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/candidate_window_unittest.cc
diff --git a/ui/base/ime/candidate_window_unittest.cc b/ui/base/ime/candidate_window_unittest.cc
index c408f5f74a4324ce0379cccfd14ef77ebc8bc981..4defe56b5e062299d89b96df5b4509eee8614271 100644
--- a/ui/base/ime/candidate_window_unittest.cc
+++ b/ui/base/ime/candidate_window_unittest.cc
@@ -10,6 +10,7 @@
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
+#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ui {
@@ -39,8 +40,8 @@ TEST(CandidateWindow, IsEqualTest) {
CandidateWindow cw1;
CandidateWindow cw2;
- const char kSampleString1[] = "Sample 1";
- const char kSampleString2[] = "Sample 2";
+ const base::string16 kSampleString1 = base::UTF8ToUTF16("Sample 1");
+ const base::string16 kSampleString2 = base::UTF8ToUTF16("Sample 2");
EXPECT_TRUE(cw1.IsEqual(cw2));
EXPECT_TRUE(cw2.IsEqual(cw1));
@@ -136,7 +137,7 @@ TEST(CandidateWindow, CopyFromTest) {
CandidateWindow cw1;
CandidateWindow cw2;
- const char kSampleString[] = "Sample";
+ const base::string16 kSampleString = base::UTF8ToUTF16("Sample");
cw1.set_page_size(1);
cw1.set_cursor_position(2);
@@ -161,9 +162,9 @@ TEST(CandidateWindow, GetInfolistEntries_DenseCase) {
candidate_window.set_page_size(10);
for (size_t i = 0; i < kSampleCandidateSize; ++i) {
CandidateWindow::Entry entry;
- entry.value = kSampleCandidate[i];
- entry.description_title = kSampleDescriptionTitle[i];
- entry.description_body = kSampleDescriptionBody[i];
+ entry.value = base::UTF8ToUTF16(kSampleCandidate[i]);
+ entry.description_title = base::UTF8ToUTF16(kSampleDescriptionTitle[i]);
+ entry.description_body = base::UTF8ToUTF16(kSampleDescriptionBody[i]);
candidate_window.mutable_candidates()->push_back(entry);
}
candidate_window.set_cursor_position(1);
@@ -183,14 +184,16 @@ TEST(CandidateWindow, GetInfolistEntries_SparseCase) {
candidate_window.set_page_size(10);
for (size_t i = 0; i < kSampleCandidateSize; ++i) {
CandidateWindow::Entry entry;
- entry.value = kSampleCandidate[i];
+ entry.value = base::UTF8ToUTF16(kSampleCandidate[i]);
candidate_window.mutable_candidates()->push_back(entry);
}
std::vector<CandidateWindow::Entry>* candidates =
candidate_window.mutable_candidates();
- (*candidates)[2].description_title = kSampleDescriptionTitle[2];
- (*candidates)[2].description_body = kSampleDescriptionBody[2];
+ (*candidates)[2].description_title =
+ base::UTF8ToUTF16(kSampleDescriptionTitle[2]);
+ (*candidates)[2].description_body =
+ base::UTF8ToUTF16(kSampleDescriptionBody[2]);
candidate_window.set_cursor_position(2);
@@ -211,14 +214,16 @@ TEST(CandidateWindow, GetInfolistEntries_SparseNoSelectionCase) {
for (size_t i = 0; i < kSampleCandidateSize; ++i) {
CandidateWindow::Entry entry;
- entry.value = kSampleCandidate[i];
+ entry.value = base::UTF8ToUTF16(kSampleCandidate[i]);
candidate_window.mutable_candidates()->push_back(entry);
}
std::vector<CandidateWindow::Entry>* candidates =
candidate_window.mutable_candidates();
- (*candidates)[2].description_title = kSampleDescriptionTitle[2];
- (*candidates)[2].description_body = kSampleDescriptionBody[2];
+ (*candidates)[2].description_title =
+ base::UTF8ToUTF16(kSampleDescriptionTitle[2]);
+ (*candidates)[2].description_body =
+ base::UTF8ToUTF16(kSampleDescriptionBody[2]);
candidate_window.set_cursor_position(0);
@@ -240,7 +245,7 @@ TEST(CandidateWindow, GetInfolistEntries_NoInfolistCase) {
for (size_t i = 0; i < kSampleCandidateSize; ++i) {
CandidateWindow::Entry entry;
- entry.value = kSampleCandidate[i];
+ entry.value = base::UTF8ToUTF16(kSampleCandidate[i]);
candidate_window.mutable_candidates()->push_back(entry);
}
candidate_window.set_cursor_position(1);
« no previous file with comments | « ui/base/ime/candidate_window.cc ('k') | ui/base/ime/chromeos/ime_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698