Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 162723003: Migrate CandidateWindow::Entry to string16. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix browsertest compilation Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | ui/base/ime/candidate_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
index 69a602ae25859efe94d871b6f2253a938bf618c0..62d2a687e61f248ac6c245ef101e72003791c9c4 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "base/bind_helpers.h"
+#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_test_message_listener.h"
#include "chromeos/ime/component_extension_ime_manager.h"
@@ -702,20 +703,28 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineIBusBrowserTest,
ASSERT_EQ(4U, table.candidates().size());
- EXPECT_EQ("CANDIDATE_1", table.candidates().at(0).value);
-
- EXPECT_EQ("CANDIDATE_2", table.candidates().at(1).value);
- EXPECT_EQ("LABEL_2", table.candidates().at(1).label);
-
- EXPECT_EQ("CANDIDATE_3", table.candidates().at(2).value);
- EXPECT_EQ("LABEL_3", table.candidates().at(2).label);
- EXPECT_EQ("ANNOTACTION_3", table.candidates().at(2).annotation);
-
- EXPECT_EQ("CANDIDATE_4", table.candidates().at(3).value);
- EXPECT_EQ("LABEL_4", table.candidates().at(3).label);
- EXPECT_EQ("ANNOTACTION_4", table.candidates().at(3).annotation);
- EXPECT_EQ("TITLE_4", table.candidates().at(3).description_title);
- EXPECT_EQ("BODY_4", table.candidates().at(3).description_body);
+ EXPECT_EQ(base::UTF8ToUTF16("CANDIDATE_1"),
+ table.candidates().at(0).value);
+
+ EXPECT_EQ(base::UTF8ToUTF16("CANDIDATE_2"),
+ table.candidates().at(1).value);
+ EXPECT_EQ(base::UTF8ToUTF16("LABEL_2"), table.candidates().at(1).label);
+
+ EXPECT_EQ(base::UTF8ToUTF16("CANDIDATE_3"),
+ table.candidates().at(2).value);
+ EXPECT_EQ(base::UTF8ToUTF16("LABEL_3"), table.candidates().at(2).label);
+ EXPECT_EQ(base::UTF8ToUTF16("ANNOTACTION_3"),
+ table.candidates().at(2).annotation);
+
+ EXPECT_EQ(base::UTF8ToUTF16("CANDIDATE_4"),
+ table.candidates().at(3).value);
+ EXPECT_EQ(base::UTF8ToUTF16("LABEL_4"), table.candidates().at(3).label);
+ EXPECT_EQ(base::UTF8ToUTF16("ANNOTACTION_4"),
+ table.candidates().at(3).annotation);
+ EXPECT_EQ(base::UTF8ToUTF16("TITLE_4"),
+ table.candidates().at(3).description_title);
+ EXPECT_EQ(base::UTF8ToUTF16("BODY_4"),
+ table.candidates().at(3).description_body);
}
{
SCOPED_TRACE("setCursorPosition test");
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | ui/base/ime/candidate_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698