Update legacy bisect to post results to perf dashboard.

Update legacy bisect to post results to perf dashboard.

Since we're moving away from this, no change in the current results reporting here.

BUG=573308
Committed: https://crrev.com/4550f726fecaa39bb479626907a4a80bbd702c3d
Cr-Commit-Position: refs/heads/master@{#376829}

[chrisphan, 2016-01-23 00:57:10]

Description was changed from

==========
Update legacy bisect to post results to perf dashboard.

BUG=573308
==========

to

==========
Update legacy bisect to post results to perf dashboard.

Since we're moving away from this, no change in the current results reporting
here.

BUG=573308
==========

[chrisphan, 2016-01-23 00:57:10]

chrisphan@chromium.org changed reviewers:
+ prasadv@chromium.org, qyearsley@chromium.org, robertocn@chromium.org

[chrisphan, 2016-01-23 00:58:33]

https://codereview.chromium.org/1625573004/diff/1/tools/auto_bisect/bisect_re...
File tools/auto_bisect/bisect_results_json.py (right):

https://codereview.chromium.org/1625573004/diff/1/tools/auto_bisect/bisect_re...
tools/auto_bisect/bisect_results_json.py:1: # Copyright 2016 The Chromium
Authors. All rights reserved.
Put this separately here to differentiate from bisect_results.py,  if you'd this
to be moved somewhere, let me know.

[qyearsley, 2016-01-26 18:08:01]

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
File tools/auto_bisect/bisect_perf_regression_test.py (right):

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression_test.py:135: """Gets the list of called
arguements for call at "call_index".
arguements -> arguments

"call_index" -> |call_index|.

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression_test.py:139: call_index: The index at
which the mocked function was called.
Is this the index in the sequence of calls? e.g. 0 means first call, 1 means
second call?

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression_test.py:180:
#_AbortIfThereAreStagedChanges()
Uncomment

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression_test.py:341: """Bisects with
improvement direction matching regression range."""
Docstring should be deleted or updated.

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression_test.py:342: # Test result goes from 0
to 100 where lower is better
This comment appears to be unrelated.

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_perf_regression_test.py:350:
bisect_perf_regression._PostBisectResults(results, opts, os.getcwd())
Optional: Because the purpose of this test method is only to test posting, not
to test a dry run, instead of calling _GenericDryRun above we could just
potentially just construct a results object here directly.

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
File tools/auto_bisect/bisect_results_json.py (right):

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_results_json.py:5: 
No need for two blank lines before the imports

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_results_json.py:18: status = 'completed'
Note: (As noted in another CL) previously "status" included either Positive or
Negative, in https://codereview.chromium.org/1573293002 we'll have to make sure
that the dashboard correctly CCs authors given the score.

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_results_json.py:60: def _revision_data(bisect_results,
depot_registry):
Method names here (in the chromium repo) are CamelCase, e.g. Get, _CulpritData,
_RevisionData.

[prasadv, 2016-02-09 21:20:38]

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
File tools/auto_bisect/bisect_results_json.py (right):

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_results_json.py:10: def get(bisect_results, opts,
depot_registry):
Method names areinconsistent with other modules

https://codereview.chromium.org/1625573004/diff/40001/tools/auto_bisect/bisec...
tools/auto_bisect/bisect_results_json.py:24: 'buildbot_log_url': '',  #
TODO(chrisphan) Get this.
Is it possible to use bot environmental variables to get these details?
BUILDBOT_BUILDBOTURL
BUILDBOT_BUILDERNAME
BUILDBOT_BUILDNUMBER

[chrisphan, 2016-02-10 02:23:38]

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
File tools/auto_bisect/bisect_perf_regression_test.py (right):

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_perf_regression_test.py:135: """Gets the list of called
arguements for call at "call_index".
On 2016/01/26 18:08:01, qyearsley wrote:
> arguements -> arguments
> 
> "call_index" -> |call_index|.

Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_perf_regression_test.py:139: call_index: The index at
which the mocked function was called.
On 2016/01/26 18:08:00, qyearsley wrote:
> Is this the index in the sequence of calls? e.g. 0 means first call, 1 means
> second call?

That's correct.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_perf_regression_test.py:180:
#_AbortIfThereAreStagedChanges()
On 2016/01/26 18:08:00, qyearsley wrote:
> Uncomment

Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_perf_regression_test.py:341: """Bisects with
improvement direction matching regression range."""
On 2016/01/26 18:08:00, qyearsley wrote:
> Docstring should be deleted or updated.

Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_perf_regression_test.py:342: # Test result goes from 0
to 100 where lower is better
On 2016/01/26 18:08:01, qyearsley wrote:
> This comment appears to be unrelated.

Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_perf_regression_test.py:350:
bisect_perf_regression._PostBisectResults(results, opts, os.getcwd())
On 2016/01/26 18:08:00, qyearsley wrote:
> Optional: Because the purpose of this test method is only to test posting, not
> to test a dry run, instead of calling _GenericDryRun above we could just
> potentially just construct a results object here directly.

Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
File tools/auto_bisect/bisect_results_json.py (right):

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:5: 
On 2016/01/26 18:08:01, qyearsley wrote:
> No need for two blank lines before the imports

Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:10: def get(bisect_results, opts,
depot_registry):
On 2016/02/09 21:20:38, prasadv wrote:
> Method names areinconsistent with other modules

What are you looking for here?  get_bisect_results/get_results?

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:18: status = 'completed'
On 2016/01/26 18:08:01, qyearsley wrote:
> Note: (As noted in another CL) previously "status" included either Positive or
> Negative, in https://codereview.chromium.org/1573293002 we'll have to make
sure
> that the dashboard correctly CCs authors given the score.

Added this check in CL/1566013002.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:24: 'buildbot_log_url': '',  #
TODO(chrisphan) Get this.
On 2016/02/09 21:20:38, prasadv wrote:
> Is it possible to use bot environmental variables to get these details?
> BUILDBOT_BUILDBOTURL
> BUILDBOT_BUILDERNAME
> BUILDBOT_BUILDNUMBER

Thanks for that.  Done.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:60: def _revision_data(bisect_results,
depot_registry):
On 2016/01/26 18:08:01, qyearsley wrote:
> Method names here (in the chromium repo) are CamelCase, e.g. Get,
_CulpritData,
> _RevisionData.

Done.

[qyearsley, 2016-02-10 02:53:53]

LGTM; Should rename bisect_results_json.get to Get before submitting.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
File tools/auto_bisect/bisect_results_json.py (right):

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:10: def get(bisect_results, opts,
depot_registry):
On 2016/02/10 02:23:38, chrisphan wrote:
> On 2016/02/09 21:20:38, prasadv wrote:
> > Method names areinconsistent with other modules
> 
> What are you looking for here?  get_bisect_results/get_results?

Function names in Chromium repo are CapitalCamelCase, so this method should be
Get.

https://chromiumcodereview-hr.appspot.com/1625573004/diff/40001/tools/auto_bi...
tools/auto_bisect/bisect_results_json.py:18: status = 'completed'
On 2016/02/10 02:23:38, chrisphan wrote:
> On 2016/01/26 18:08:01, qyearsley wrote:
> > Note: (As noted in another CL) previously "status" included either Positive
or
> > Negative, in https://codereview.chromium.org/1573293002 we'll have to make
> sure
> > that the dashboard correctly CCs authors given the score.
> 
> Added this check in CL/1566013002.
> 

SGTM

[robertocn1, 2016-02-22 21:33:07]

robertocn@google.com changed reviewers:
+ robertocn@google.com

[robertocn1, 2016-02-22 21:33:08]

The CQ bit was checked by robertocn@google.com

[robertocn1, 2016-02-22 21:33:08]

lgtm

[robertocn1, 2016-02-22 21:33:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset:
https://chromiumcodereview-hr.appspot.com/1625573004/#ps80001 (title: "update")

[commit-bot: I haz the power, 2016-02-22 21:38:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1625573004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1625573004/80001

[commit-bot: I haz the power, 2016-02-22 22:38:03]

Description was changed from

==========
Update legacy bisect to post results to perf dashboard.

Since we're moving away from this, no change in the current results reporting
here.

BUG=573308
==========

to

==========
Update legacy bisect to post results to perf dashboard.

Since we're moving away from this, no change in the current results reporting
here.

BUG=573308
==========

[commit-bot: I haz the power, 2016-02-22 22:38:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-22 22:39:12]

Description was changed from

==========
Update legacy bisect to post results to perf dashboard.

Since we're moving away from this, no change in the current results reporting
here.

BUG=573308
==========

to

==========
Update legacy bisect to post results to perf dashboard.

Since we're moving away from this, no change in the current results reporting
here.

BUG=573308

Committed: https://crrev.com/4550f726fecaa39bb479626907a4a80bbd702c3d
Cr-Commit-Position: refs/heads/master@{#376829}
==========

[commit-bot: I haz the power, 2016-02-22 22:39:13]

Patchset 5 (id:??) landed as
https://crrev.com/4550f726fecaa39bb479626907a4a80bbd702c3d
Cr-Commit-Position: refs/heads/master@{#376829}