Update legacy bisect to post results to perf dashboard.

tools/auto_bisect/bisect_perf_regression_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import shutil
 import sys
 import unittest
 
@@ skipping 113 matching lines @@
 
 def _FakeTestResult(values, bisect_mode_is_return_code):
   mean = 0.0
   if bisect_mode_is_return_code:
     mean = 0 if (all(v == 0 for v in values)) else 1
   result_dict = {'mean': mean, 'std_err': 0.0, 'std_dev': 0.0, 'values': values}
   success_code = 0
   return (result_dict, success_code)
 
 
+def _GetMockCallArg(function_mock, call_index):
+  """Gets the list of called arguements for call at "call_index".

[qyearsley, 2016/01/26 18:08:01]

arguements -> arguments

"call_index" -> |call_index|.

[chrisphan, 2016/02/10 02:23:38]

Done.

+
+  Args:
+    function_mock: A Mock object.
+    call_index: The index at which the mocked function was called.

[qyearsley, 2016/01/26 18:08:00]

Is this the index in the sequence of calls? e.g. 0 means first call, 1 means
second call?

[chrisphan, 2016/02/10 02:23:38]

That's correct.

+
+  Returns:
+    The called argument list.
+  """
+  call_args_list = function_mock.call_args_list
+  if not call_args_list or len(call_args_list) <= call_index:
+    return None
+  args, _ = call_args_list[call_index]
+  return args
+
+
 def _GetBisectPerformanceMetricsInstance(options_dict):
   """Returns an instance of the BisectPerformanceMetrics class."""
   opts = bisect_perf_regression.BisectOptions.FromDict(options_dict)
   return bisect_perf_regression.BisectPerformanceMetrics(opts, os.getcwd())
 
 
 def _GetExtendedOptions(improvement_dir, fake_first, ignore_confidence=True,
                         **extra_opts):
   """Returns the a copy of the default options dict plus some options."""
   result = dict(DEFAULT_OPTIONS)
   result.update({
       'improvement_direction': improvement_dir,
       'debug_fake_first_test_mean': fake_first,
       'debug_ignore_regression_confidence': ignore_confidence
   })
   result.update(extra_opts)
   return result
 
 
 def _GenericDryRun(options, print_results=False):
   """Performs a dry run of the bisector.
 
   Args:
     options: Dictionary containing the options for the bisect instance.
     print_results: Boolean telling whether to call FormatAndPrintResults.
 
   Returns:
     The results dictionary as returned by the bisect Run method.
   """
-  _AbortIfThereAreStagedChanges()
+  #_AbortIfThereAreStagedChanges()

[qyearsley, 2016/01/26 18:08:00]

Uncomment

[chrisphan, 2016/02/10 02:23:38]

Done.

   # Disable rmtree to avoid deleting local trees.
   old_rmtree = shutil.rmtree
   shutil.rmtree = lambda path, on_error: None
   # git reset HEAD may be run during the dry run, which removes staged changes.
   try:
     bisect_instance = _GetBisectPerformanceMetricsInstance(options)
     results = bisect_instance.Run(
         bisect_instance.opts.command, bisect_instance.opts.bad_revision,
         bisect_instance.opts.good_revision, bisect_instance.opts.metric)
 
@@ skipping 138 matching lines @@
 
   def testBisectImprovementDirectionSucceeds(self):
     """Bisects with improvement direction matching regression range."""
     # Test result goes from 0 to 100 where lower is better
     results = _GenericDryRun(_GetExtendedOptions(-1, 100))
     self.assertIsNone(results.error)
     # Test result goes from 0 to -100 where higher is better
     results = _GenericDryRun(_GetExtendedOptions(1, -100))
     self.assertIsNone(results.error)
 
+  @mock.patch('urllib2.urlopen')
+  def testBisectResultsPosted(self, mock_urlopen):
+    """Bisects with improvement direction matching regression range."""

[qyearsley, 2016/01/26 18:08:00]

Docstring should be deleted or updated.

[chrisphan, 2016/02/10 02:23:38]

Done.

+    # Test result goes from 0 to 100 where lower is better

[qyearsley, 2016/01/26 18:08:01]

This comment appears to be unrelated.

[chrisphan, 2016/02/10 02:23:38]

Done.

+    options_dict = dict(DEFAULT_OPTIONS)
+    options_dict.update({
+        'bisect_mode': bisect_utils.BISECT_MODE_MEAN,
+        'try_job_id': 1234,
+    })
+    opts = bisect_perf_regression.BisectOptions.FromDict(options_dict)
+    results = _GenericDryRun(options_dict, True)
+    bisect_perf_regression._PostBisectResults(results, opts, os.getcwd())

[qyearsley, 2016/01/26 18:08:00]

Optional: Because the purpose of this test method is only to test posting, not
to test a dry run, instead of calling _GenericDryRun above we could just
potentially just construct a results object here directly.

[chrisphan, 2016/02/10 02:23:38]

Done.

+
+    call_args = _GetMockCallArg(mock_urlopen, 0)
+    self.assertIsNotNone(call_args)
+    self.assertIn('"try_job_id": 1234', call_args[1])
+
   def _CheckAbortsEarly(self, results, **extra_opts):
     """Returns True if the bisect job would abort early."""
     global _MockResultsGenerator
     _MockResultsGenerator = (r for r in results)
     bisect_class = bisect_perf_regression.BisectPerformanceMetrics
     original_run_tests = bisect_class.RunPerformanceTestAndParseResults
     bisect_class.RunPerformanceTestAndParseResults = _MakeMockRunTests()
 
     try:
       dry_run_results = _GenericDryRun(_GetExtendedOptions(
@@ skipping 355 matching lines @@
          (None, 0)),
     ]
     self._SetupRunGitMock(try_cmd)
     bisect_perf_regression._StartBuilderTryJob(
         fetch_build.PERF_BUILDER, git_revision, bot_name, bisect_job_name,
         patch)
 
 
 if __name__ == '__main__':
   unittest.main()