Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3281)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 162423002: [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
index 0e12b56b83dfc05d8ed4fdc20534c2c19e4f9934..36336f02efe22f23731b7c615cdf6a20e72c48e7 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
@@ -188,3 +188,20 @@ TEST_F(PermissionBubbleManagerTest, TwoRequestsTabSwitch) {
EXPECT_FALSE(request2_.granted_);
}
+TEST_F(PermissionBubbleManagerTest, SequentialRequests) {
+ manager_->SetView(&view_);
+ manager_->AddRequest(&request1_);
+ EXPECT_TRUE(view_.shown_);
+
+ manager_->AddRequest(&request2_);
leng 2014/02/13 01:12:45 It's not clear to me why you're adding request2 tw
Greg Billock 2014/02/13 01:39:22 Thanks. This was just exercising a log line to mak
+ Accept();
+ EXPECT_TRUE(request1_.granted_);
+
+ EXPECT_FALSE(view_.shown_);
+
+ manager_->AddRequest(&request2_);
+ EXPECT_TRUE(view_.shown_);
+ Accept();
+ EXPECT_FALSE(view_.shown_);
+ EXPECT_TRUE(request2_.granted_);
+}
« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698