Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6735)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 162423002: [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index cb3df39d6b39ba73206ca70d492a2a430354a009..0e6a3bebf1ef7bef30c901874ec3ce05b806397d 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -32,7 +32,6 @@ void PermissionBubbleManager::AddRequest(PermissionBubbleRequest* request) {
// with various states of the manager.
if (view_ && !bubble_showing_) {
- view_->SetDelegate(this);
view_->Show(requests_, accept_state_, customization_mode_);
bubble_showing_ = true;
}
@@ -124,10 +123,9 @@ void PermissionBubbleManager::Closing() {
}
void PermissionBubbleManager::FinalizeBubble() {
- if (view_) {
- view_->SetDelegate(NULL);
+ if (view_)
view_->Hide();
- }
+ bubble_showing_ = false;
std::vector<PermissionBubbleRequest*>::iterator di;
for (di = requests_.begin(); di != requests_.end(); di++)

Powered by Google App Engine
This is Rietveld 408576698