[WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed.

chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
 #include "chrome/browser/ui/website_settings/permission_bubble_view.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 170 matching lines @@
   EXPECT_EQ(&request1_, view_.permission_requests_[0]);
   EXPECT_EQ(&request2_, view_.permission_requests_[1]);
   EXPECT_TRUE(view_.permission_states_[0]);
   EXPECT_FALSE(view_.permission_states_[1]);
 
   Accept();
   EXPECT_TRUE(request1_.granted_);
   EXPECT_FALSE(request2_.granted_);
 }
 
+TEST_F(PermissionBubbleManagerTest, SequentialRequests) {
+  manager_->SetView(&view_);
+  manager_->AddRequest(&request1_);
+  EXPECT_TRUE(view_.shown_);
+
+  manager_->AddRequest(&request2_);

[leng, 2014/02/13 01:12:45]

It's not clear to me why you're adding request2 twice, because you're not
checking that it wasn't shown, or granted.  Perhaps add
EXPECT_FALSE(request2_.granted_); after EXPECT_TRUE(request1_.granted_)?

[Greg Billock, 2014/02/13 01:39:22]

Thanks. This was just exercising a log line to make sure the bug was there and
that this fixed it.

+  Accept();
+  EXPECT_TRUE(request1_.granted_);
+
+  EXPECT_FALSE(view_.shown_);
+
+  manager_->AddRequest(&request2_);
+  EXPECT_TRUE(view_.shown_);
+  Accept();
+  EXPECT_FALSE(view_.shown_);
+  EXPECT_TRUE(request2_.granted_);
+}