Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1623453002: Revert of experiment: float color components (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
herb_g, f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of experiment: float color components (patchset #6 id:100001 of https://codereview.chromium.org/1617813002/ ) Reason for revert: broke some colormatrix tests Original issue's description: > experiment: float color components > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617813002 > > Committed: https://skia.googlesource.com/skia/+/353c148d8e8c9031daca34c6f9d6bcc6f08706c7 TBR=fmalita@chromium.org,mtklein@google.com,herb@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2a2bdc698460c38ac9e24ba4abdeefec67bcba37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -219 lines) Patch
M include/core/SkColor.h View 1 chunk +0 lines, -40 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +1 line, -4 lines 0 comments Download
M include/core/SkColorPriv.h View 1 chunk +0 lines, -5 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +0 lines, -3 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkColor.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkMathPriv.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkShader.cpp View 3 chunks +1 line, -15 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 chunks +19 lines, -45 lines 0 comments Download
D tests/SkColor4fTest.cpp View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of experiment: float color components
4 years, 11 months ago (2016-01-22 08:04:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623453002/1
4 years, 11 months ago (2016-01-22 08:04:23 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 08:04:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a2bdc698460c38ac9e24ba4abdeefec67bcba37

Powered by Google App Engine
This is Rietveld 408576698