Issue 16226024: Add LoadIC_Slow builtin and use it for loading properties from primitive values.

Issue 16226024: Add LoadIC_Slow builtin and use it for loading properties from primitive values. (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow

Modified:
7 years, 6 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add LoadIC_Slow builtin and use it for loading properties from primitive values. This fixes recent performance regressions on Dromaeo. BUG=chromium:242512 R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14950

Patch Set 2 : addressed comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -9 lines)			Patch
M	src/arm/ic-arm.cc	View	1	3 chunks	+15 lines, -6 lines	0 comments	Download
M	src/builtins.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/builtins.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/ic.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	src/x64/ic-x64.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with comment https://codereview.chromium.org/16226024/diff/2001/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): https://codereview.chromium.org/16226024/diff/2001/src/arm/ic-arm.cc#newcode722 src/arm/ic-arm.cc:722: __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1); Please call ...

7 years, 6 months ago (2013-06-04 17:51:08 UTC) #2

Jakob Kummerow

Landing. https://codereview.chromium.org/16226024/diff/2001/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): https://codereview.chromium.org/16226024/diff/2001/src/arm/ic-arm.cc#newcode722 src/arm/ic-arm.cc:722: __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1); On 2013/06/04 17:51:08, Toon ...

7 years, 6 months ago (2013-06-05 11:11:51 UTC) #3

Jakob Kummerow

7 years, 6 months ago (2013-06-05 11:12:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14950 (presubmit successful).

Expand Messages | Collapse Messages