Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/x64/ic-x64.cc

Issue 16226024: Add LoadIC_Slow builtin and use it for loading properties from primitive values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
1373 __ push(rcx); // name 1373 __ push(rcx); // name
1374 __ push(rbx); // return address 1374 __ push(rbx); // return address
1375 1375
1376 // Perform tail call to the entry. 1376 // Perform tail call to the entry.
1377 ExternalReference ref = 1377 ExternalReference ref =
1378 ExternalReference(IC_Utility(kLoadIC_Miss), masm->isolate()); 1378 ExternalReference(IC_Utility(kLoadIC_Miss), masm->isolate());
1379 __ TailCallExternalReference(ref, 2, 1); 1379 __ TailCallExternalReference(ref, 2, 1);
1380 } 1380 }
1381 1381
1382 1382
1383 void LoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) {
1384 // ----------- S t a t e -------------
1385 // -- rax : receiver
1386 // -- rcx : name
1387 // -- rsp[0] : return address
1388 // -----------------------------------
1389
1390 __ pop(rbx);
1391 __ push(rax); // receiver
1392 __ push(rcx); // name
1393 __ push(rbx); // return address
1394
1395 // Perform tail call to the entry.
1396 __ TailCallRuntime(Runtime::kGetProperty, 2, 1);
1397 }
1398
1399
1383 void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) { 1400 void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
1384 // ----------- S t a t e ------------- 1401 // ----------- S t a t e -------------
1385 // -- rax : key 1402 // -- rax : key
1386 // -- rdx : receiver 1403 // -- rdx : receiver
1387 // -- rsp[0] : return address 1404 // -- rsp[0] : return address
1388 // ----------------------------------- 1405 // -----------------------------------
1389 1406
1390 Counters* counters = masm->isolate()->counters(); 1407 Counters* counters = masm->isolate()->counters();
1391 __ IncrementCounter(counters->keyed_load_miss(), 1); 1408 __ IncrementCounter(counters->keyed_load_miss(), 1);
1392 1409
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
1707 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1724 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1708 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1725 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1709 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1726 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1710 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1727 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1711 } 1728 }
1712 1729
1713 1730
1714 } } // namespace v8::internal 1731 } } // namespace v8::internal
1715 1732
1716 #endif // V8_TARGET_ARCH_X64 1733 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698