Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 16226024: Add LoadIC_Slow builtin and use it for loading properties from primitive values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1336 matching lines...) Expand 10 before | Expand all | Expand 10 after
1347 __ push(ecx); // name 1347 __ push(ecx); // name
1348 __ push(ebx); // return address 1348 __ push(ebx); // return address
1349 1349
1350 // Perform tail call to the entry. 1350 // Perform tail call to the entry.
1351 ExternalReference ref = 1351 ExternalReference ref =
1352 ExternalReference(IC_Utility(kLoadIC_Miss), masm->isolate()); 1352 ExternalReference(IC_Utility(kLoadIC_Miss), masm->isolate());
1353 __ TailCallExternalReference(ref, 2, 1); 1353 __ TailCallExternalReference(ref, 2, 1);
1354 } 1354 }
1355 1355
1356 1356
1357 void LoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) {
1358 // ----------- S t a t e -------------
1359 // -- ecx : key
1360 // -- edx : receiver
1361 // -- esp[0] : return address
1362 // -----------------------------------
1363
1364 __ pop(ebx);
1365 __ push(edx); // receiver
1366 __ push(ecx); // name
1367 __ push(ebx); // return address
1368
1369 // Perform tail call to the entry.
1370 __ TailCallRuntime(Runtime::kGetProperty, 2, 1);
1371 }
1372
1373
1357 void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) { 1374 void KeyedLoadIC::GenerateMiss(MacroAssembler* masm, ICMissMode miss_mode) {
1358 // ----------- S t a t e ------------- 1375 // ----------- S t a t e -------------
1359 // -- ecx : key 1376 // -- ecx : key
1360 // -- edx : receiver 1377 // -- edx : receiver
1361 // -- esp[0] : return address 1378 // -- esp[0] : return address
1362 // ----------------------------------- 1379 // -----------------------------------
1363 1380
1364 __ IncrementCounter(masm->isolate()->counters()->keyed_load_miss(), 1); 1381 __ IncrementCounter(masm->isolate()->counters()->keyed_load_miss(), 1);
1365 1382
1366 __ pop(ebx); 1383 __ pop(ebx);
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1693 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1710 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1694 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1711 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1695 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1712 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1696 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1713 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1697 } 1714 }
1698 1715
1699 1716
1700 } } // namespace v8::internal 1717 } } // namespace v8::internal
1701 1718
1702 #endif // V8_TARGET_ARCH_IA32 1719 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698