Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1621943002: ICU 56 step 4: Apply post-56 fixes for measure/date format (Closed)

Created:
4 years, 11 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@56goog
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ICU 56 step 4: Apply post-56 fixes for measure/date format 1. Apply post-56 patches from the trunk for measure/date format http://bugs.icu-project.org/trac/ticket/11986 http://bugs.icu-project.org/trac/ticket/12031 http://bugs.icu-project.org/trac/ticket/12030 http://bugs.icu-project.org/trac/ticket/12041 2. Generate a combined patch (measure_format.patch) for the above. 3. Split locale_google.patch into 'locale_google.patch' and 'relative_date.patch'. The latter is taken from Android. 4. Update README.chromium Besides, apply two local patches : {tzdetect,xlit..}.patch and adjust gb18030.ucm and the corresponding patch Also, remove obsolte patches and update README.chromium BUG=575007 R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/825221bbc2787a82432a26e1e444595f5c4a635c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7400 lines, -3614 lines) Patch
M README.chromium View 5 chunks +75 lines, -120 lines 0 comments Download
D patches/bidi.patch View 1 chunk +0 lines, -70 lines 0 comments Download
D patches/dataload.patch View 1 chunk +0 lines, -152 lines 0 comments Download
M patches/gb_table.patch View 1 chunk +10 lines, -3 lines 0 comments Download
D patches/infinite-recursion.patch View 1 chunk +0 lines, -81 lines 0 comments Download
M patches/locale_google.patch View 1 chunk +0 lines, -48 lines 0 comments Download
D patches/locid.patch View 1 chunk +0 lines, -331 lines 0 comments Download
A patches/measure_format.patch View 1 chunk +5474 lines, -0 lines 0 comments Download
D patches/mutex.patch View 1 chunk +0 lines, -110 lines 0 comments Download
D patches/pkg_gen.patch View 1 chunk +0 lines, -37 lines 0 comments Download
D patches/platform_nacl.patch View 1 chunk +0 lines, -25 lines 0 comments Download
A patches/relative_date.patch View 1 chunk +48 lines, -0 lines 0 comments Download
D patches/stringthreadtest.patch View 1 chunk +0 lines, -20 lines 0 comments Download
M patches/tzdetect.patch View 1 chunk +41 lines, -191 lines 0 comments Download
D patches/tzdetect2.patch View 1 chunk +0 lines, -50 lines 0 comments Download
D patches/ucnv_name.patch View 1 chunk +0 lines, -13 lines 0 comments Download
D patches/ucnv_refcount.patch View 1 chunk +0 lines, -668 lines 0 comments Download
D patches/uloc.patch View 1 chunk +0 lines, -13 lines 0 comments Download
D patches/woverloaded-virtual.patch View 1 chunk +0 lines, -74 lines 0 comments Download
M scripts/data_files_to_preserve.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/common/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/common/common.vcxproj View 2 chunks +3 lines, -1 line 0 comments Download
M source/common/common.vcxproj.filters View 2 chunks +7 lines, -1 line 0 comments Download
M source/common/listformatter.cpp View 3 chunks +12 lines, -7 lines 0 comments Download
M source/common/putil.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M source/common/putilimp.h View 1 chunk +6 lines, -0 lines 0 comments Download
A source/common/resource.h View 1 chunk +248 lines, -0 lines 0 comments Download
A source/common/resource.cpp View 1 chunk +60 lines, -0 lines 0 comments Download
M source/common/simplepatternformatter.h View 3 chunks +28 lines, -3 lines 0 comments Download
M source/common/simplepatternformatter.cpp View 5 chunks +21 lines, -3 lines 0 comments Download
M source/common/uresbund.cpp View 1 chunk +115 lines, -0 lines 0 comments Download
M source/common/uresdata.h View 1 chunk +58 lines, -2 lines 0 comments Download
D source/common/uresdata.c View 1 chunk +0 lines, -1169 lines 0 comments Download
A + source/common/uresdata.cpp View 11 chunks +310 lines, -13 lines 0 comments Download
M source/common/uresimp.h View 2 chunks +13 lines, -1 line 0 comments Download
A source/common/uresource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A source/common/uresource.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M source/data/mappings/gb18030.ucm View 2 chunks +1 line, -1 line 0 comments Download
M source/data/unit/ar.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/de.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/dsb.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M source/data/unit/hsb.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M source/data/unit/lv.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M source/data/unit/my.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M source/data/unit/pt_PT.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/ro.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/si.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/sr.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/sr_Latn.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/unit/tr.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M source/i18n/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/i18n/i18n.vcxproj View 2 chunks +2 lines, -0 lines 0 comments Download
M source/i18n/i18n.vcxproj.filters View 2 chunks +6 lines, -0 lines 0 comments Download
M source/i18n/measfmt.cpp View 13 chunks +313 lines, -192 lines 0 comments Download
M source/i18n/measunit.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M source/i18n/plurrule_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M source/i18n/quantityformatter.h View 4 chunks +37 lines, -17 lines 0 comments Download
M source/i18n/quantityformatter.cpp View 3 chunks +76 lines, -71 lines 0 comments Download
M source/i18n/rbt_pars.cpp View 1 chunk +1 line, -1 line 0 comments Download
M source/i18n/reldatefmt.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
A source/i18n/standardplural.h View 1 chunk +130 lines, -0 lines 0 comments Download
A source/i18n/standardplural.cpp View 1 chunk +127 lines, -0 lines 0 comments Download
M source/i18n/timezone.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M source/i18n/unicode/measfmt.h View 1 chunk +10 lines, -8 lines 0 comments Download
M source/i18n/unicode/measunit.h View 1 chunk +8 lines, -0 lines 0 comments Download
M source/test/depstest/dependencies.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M source/test/intltest/itformat.cpp View 3 chunks +10 lines, -2 lines 0 comments Download
M source/test/intltest/itutil.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M source/test/intltest/measfmttest.cpp View 3 chunks +15 lines, -0 lines 0 comments Download
M source/test/intltest/quantityformattertest.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M source/test/intltest/reldatefmttest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M source/test/intltest/tufmtts.h View 1 chunk +0 lines, -63 lines 0 comments Download
M source/test/intltest/tufmtts.cpp View 4 chunks +68 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
jungshik at Google
PTAL. Again nothing interesting here. It's to apply post-56 fixes (necessary because ICU 56.1 has ...
4 years, 10 months ago (2016-01-28 08:51:48 UTC) #3
Mark Mentovai
LGTM
4 years, 10 months ago (2016-01-28 14:19:10 UTC) #4
jungshik at Google
4 years, 10 months ago (2016-01-29 09:05:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
825221bbc2787a82432a26e1e444595f5c4a635c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698