Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 1637683002: ICU 56 step 5: Apply the remaining local patches (Closed)

Created:
4 years, 11 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@56post56
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Apply the remaining local patches Below is the list of changes in reverse order. 1. Drop uconv.patch (upstream took my patch) 2. Apply data.build.win and data_sym patches 3. Apply vscomp.patch and update the patch file. update README.chromium about two parts of the patch that are not necessary any more. 4. Apply wpo patch and update the patch file 5. Android brkitr adjustment * Do not apply the patch but just updates the patch * Do not use CJdict on Android to save 2MB in the data size. 6. Clean up brkitr patches * Rename brkitr.patch to wordbkr.patch and keep only word.txt diff * Make a new linebrk.patch with line breaking adjustment (dropping loose rules to save space until the upstream implements space-efficient mechanism for line breaking rule variations) * Update README.chromium * Apply local patches for Khmer dictionary handling and cjdict 7. Adjust line breaking rules. This corresponds to set 2 in https://code.google.com/p/chromium/issues/detail?id=575007#c6 BUG=575007 TEST=None R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/5dac1b26278e08b9aea9e31f8ba18a0c28436588

Patch Set 1 #

Patch Set 2 : drop uconv.patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -1137 lines) Patch
M README.chromium View 1 3 chunks +9 lines, -26 lines 0 comments Download
M android/brkitr.patch View 4 chunks +50 lines, -55 lines 0 comments Download
D patches/brkitr.patch View 1 chunk +0 lines, -79 lines 0 comments Download
A patches/linebrk.patch View 1 chunk +75 lines, -0 lines 0 comments Download
D patches/uconv.patch View 1 1 chunk +0 lines, -846 lines 0 comments Download
M patches/vscomp.patch View 2 chunks +1 line, -66 lines 0 comments Download
A patches/wordbrk.patch View 1 chunk +24 lines, -0 lines 0 comments Download
M patches/wpo.patch View 6 chunks +16 lines, -16 lines 0 comments Download
M source/common/dictbe.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M source/common/locmap.c View 2 chunks +2 lines, -0 lines 0 comments Download
M source/common/stringpiece.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M source/common/ucmndata.h View 1 chunk +14 lines, -0 lines 0 comments Download
M source/common/udata.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M source/common/unicode/utypes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M source/data/brkitr/brklocal.mk View 1 chunk +3 lines, -2 lines 0 comments Download
M source/data/brkitr/cjdict.txt View 4 chunks +7 lines, -0 lines 0 comments Download
M source/data/brkitr/fi.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M source/data/brkitr/ja.txt View 1 chunk +1 line, -1 line 0 comments Download
M source/data/brkitr/root.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/brkitr/zh.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/brkitr/zh_Hant.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/makedata.mak View 2 chunks +2 lines, -1 line 0 comments Download
M source/stubdata/stubdata.c View 1 chunk +20 lines, -31 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (8 generated)
jungshik at Google
PTAL. This is CL #5 to apply all the remaining local patches and update the ...
4 years, 10 months ago (2016-01-28 08:56:21 UTC) #8
Mark Mentovai
LGTM
4 years, 10 months ago (2016-01-28 14:19:51 UTC) #9
jungshik at Google
4 years, 10 months ago (2016-01-29 09:12:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5dac1b26278e08b9aea9e31f8ba18a0c28436588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698