Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1620203002: Extended error reporting for SVGNumber/Point/Rect and related types (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
Mitrob77, pdr., f(malita)
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extended error reporting for SVGNumber/Point/Rect and related types Add extended error reporting for "number-based" types - SVGNumber, SVGNumberList, SVGNumberOptionalNumber, SVGPoint, SVGPointList and SVGRect. Also clean up some of the parsing functions and eliminate some unnecessary clear() calls in the list types. BUG=231612 Committed: https://crrev.com/0d2259ca33d92020651e814dbfe5defe92d3e044 Cr-Commit-Position: refs/heads/master@{#371022}

Patch Set 1 #

Patch Set 2 : TestExpectations #

Patch Set 3 : Rebase. #

Patch Set 4 : Blind is blind. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -121 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumber.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumber.cpp View 1 chunk +16 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.cpp View 1 chunk +14 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberOptionalNumber.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPoint.cpp View 2 chunks +12 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointList.cpp View 1 chunk +22 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRect.cpp View 2 chunks +17 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
fs
Appearances: https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel_ng/168909/layout-test-results/results.html
4 years, 11 months ago (2016-01-22 18:54:56 UTC) #3
pdr.
Another nice one. I wish parse was called parseAndSetValue, but that's more just personal shed ...
4 years, 11 months ago (2016-01-22 19:29:42 UTC) #4
fs
On 2016/01/22 at 19:29:42, pdr wrote: > Another nice one. > > I wish parse ...
4 years, 11 months ago (2016-01-22 19:53:06 UTC) #5
f(malita)
LGTM
4 years, 11 months ago (2016-01-22 19:59:30 UTC) #6
pdr.
On 2016/01/22 at 19:53:06, fs wrote: > On 2016/01/22 at 19:29:42, pdr wrote: > > ...
4 years, 11 months ago (2016-01-22 19:59:32 UTC) #7
fs
On 2016/01/22 at 19:59:32, pdr wrote: > On 2016/01/22 at 19:53:06, fs wrote: > > ...
4 years, 11 months ago (2016-01-22 20:13:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620203002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620203002/60001
4 years, 11 months ago (2016-01-22 20:14:26 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-22 20:21:10 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0d2259ca33d92020651e814dbfe5defe92d3e044 Cr-Commit-Position: refs/heads/master@{#371022}
4 years, 11 months ago (2016-01-22 20:22:14 UTC) #13
Mitrob77_gmail.com
4 years, 10 months ago (2016-01-25 13:34:00 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698