Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGNumber.h

Issue 1620203002: Extended error reporting for SVGNumber/Point/Rect and related types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Blind is blind. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override; 60 void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
61 void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawP tr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDuratio nValue, SVGElement* contextElement) override; 61 void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawP tr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDuratio nValue, SVGElement* contextElement) override;
62 float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGEleme nt* contextElement) override; 62 float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGEleme nt* contextElement) override;
63 63
64 static AnimatedPropertyType classType() { return AnimatedNumber; } 64 static AnimatedPropertyType classType() { return AnimatedNumber; }
65 65
66 protected: 66 protected:
67 explicit SVGNumber(float); 67 explicit SVGNumber(float);
68 68
69 template<typename CharType> 69 template<typename CharType>
70 bool parse(const CharType*& ptr, const CharType* end); 70 SVGParsingError parse(const CharType*& ptr, const CharType* end);
71 71
72 float m_value; 72 float m_value;
73 }; 73 };
74 74
75 DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGNumber); 75 DEFINE_SVG_PROPERTY_TYPE_CASTS(SVGNumber);
76 76
77 // SVGNumber which also accepts percentage as its value. 77 // SVGNumber which also accepts percentage as its value.
78 // This is used for <stop> "offset" 78 // This is used for <stop> "offset"
79 // Spec: http://www.w3.org/TR/SVG11/pservers.html#GradientStops 79 // Spec: http://www.w3.org/TR/SVG11/pservers.html#GradientStops
80 // offset = "<number> | <percentage>" 80 // offset = "<number> | <percentage>"
81 class SVGNumberAcceptPercentage final : public SVGNumber { 81 class SVGNumberAcceptPercentage final : public SVGNumber {
82 public: 82 public:
83 static PassRefPtrWillBeRawPtr<SVGNumberAcceptPercentage> create(float value = 0) 83 static PassRefPtrWillBeRawPtr<SVGNumberAcceptPercentage> create(float value = 0)
84 { 84 {
85 return adoptRefWillBeNoop(new SVGNumberAcceptPercentage(value)); 85 return adoptRefWillBeNoop(new SVGNumberAcceptPercentage(value));
86 } 86 }
87 87
88 PassRefPtrWillBeRawPtr<SVGNumber> clone() const override; 88 PassRefPtrWillBeRawPtr<SVGNumber> clone() const override;
89 SVGParsingError setValueAsString(const String&) override; 89 SVGParsingError setValueAsString(const String&) override;
90 90
91 private: 91 private:
92 explicit SVGNumberAcceptPercentage(float); 92 explicit SVGNumberAcceptPercentage(float);
93 }; 93 };
94 94
95 } // namespace blink 95 } // namespace blink
96 96
97 #endif // SVGNumber_h 97 #endif // SVGNumber_h
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/svg/SVGNumber.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698