Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGParsingError.cpp

Issue 1620203002: Extended error reporting for SVGNumber/Point/Rect and related types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Blind is blind. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/svg/SVGParsingError.h" 5 #include "core/svg/SVGParsingError.h"
6 6
7 #include "core/dom/QualifiedName.h" 7 #include "core/dom/QualifiedName.h"
8 #include "platform/JSONValues.h" 8 #include "platform/JSONValues.h"
9 #include "wtf/text/CharacterNames.h" 9 #include "wtf/text/CharacterNames.h"
10 #include "wtf/text/StringBuilder.h" 10 #include "wtf/text/StringBuilder.h"
(...skipping 14 matching lines...) Expand all
25 25
26 std::pair<const char*, const char*> messageForStatus(SVGParseStatus status) 26 std::pair<const char*, const char*> messageForStatus(SVGParseStatus status)
27 { 27 {
28 switch (status) { 28 switch (status) {
29 case SVGParseStatus::TrailingGarbage: 29 case SVGParseStatus::TrailingGarbage:
30 return std::make_pair("Trailing garbage, ", "."); 30 return std::make_pair("Trailing garbage, ", ".");
31 case SVGParseStatus::ExpectedBoolean: 31 case SVGParseStatus::ExpectedBoolean:
32 return std::make_pair("Expected 'true' or 'false', ", "."); 32 return std::make_pair("Expected 'true' or 'false', ", ".");
33 case SVGParseStatus::ExpectedEnumeration: 33 case SVGParseStatus::ExpectedEnumeration:
34 return std::make_pair("Unrecognized enumerated value, ", "."); 34 return std::make_pair("Unrecognized enumerated value, ", ".");
35 case SVGParseStatus::ExpectedNumber:
36 return std::make_pair("Expected number, ", ".");
35 case SVGParseStatus::NegativeValue: 37 case SVGParseStatus::NegativeValue:
36 return std::make_pair("A negative value is not valid. (", ")"); 38 return std::make_pair("A negative value is not valid. (", ")");
37 case SVGParseStatus::ParsingFailed: 39 case SVGParseStatus::ParsingFailed:
38 default: 40 default:
39 ASSERT_NOT_REACHED(); 41 ASSERT_NOT_REACHED();
40 break; 42 break;
41 } 43 }
42 return std::make_pair("", ""); 44 return std::make_pair("", "");
43 } 45 }
44 46
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 98
97 auto message = messageForStatus(status()); 99 auto message = messageForStatus(status());
98 builder.append(message.first); 100 builder.append(message.first);
99 appendValue(builder, *this, value); 101 appendValue(builder, *this, value);
100 builder.append(message.second); 102 builder.append(message.second);
101 } 103 }
102 return builder.toString(); 104 return builder.toString();
103 } 105 }
104 106
105 } // namespace blink 107 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGParsingError.h ('k') | third_party/WebKit/Source/core/svg/SVGPoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698