Remove use of minimumValueForLength in HTMLAreaElement::getRegion

Remove use of minimumValueForLength in HTMLAreaElement::getRegion

While the 'coords' attribute on HTMLAreaElement is stored as a
Vector<Length>, the Lengths will all be of the type 'Fixed'. This means
that the only effect of minimumValueForLength() will be to round-trip
through LayoutUnit - resulting in a clamp to the allowed range of
LayoutUnit. Replace the uses of minimumValueForLength() with a new
function (clampCoordinate) that only does this clamping.

No functional changes.

BUG=578114
Committed: https://crrev.com/41260e42ad6324ca4faa72576757244bf4596218
Cr-Commit-Position: refs/heads/master@{#371184}

[fs, 2016-01-21 18:35:57]

fs@opera.com changed reviewers:
+ dominicc@chromium.org, tkent@chromium.org

[tkent, 2016-01-21 23:04:54]

This change needs a test.

According to crbug.com/578114, now web-platform-tests has a test for this,
right?  So, we should update imported web-platform-tests first.

[dominicc (has gone to gerrit), 2016-01-22 03:16:06]

dominicc@chromium.org changed reviewers:
- dominicc@chromium.org

[fs, 2016-01-22 10:15:38]

On 2016/01/21 at 23:04:54, tkent wrote:
> This change needs a test.

It does not change behavior so I don't see what would be tested.
 
> According to crbug.com/578114, now web-platform-tests has a test for this,
right?  So, we should update imported web-platform-tests first.

This is just a cleanup in preparation for fixing the real issues there. I'll
send a CL to "import" the new tests. (I say "import" because crbug.com/498120
blocks proper import. Will file a bug to block on that one.)

[fs, 2016-01-22 10:16:02]

Description was changed from

==========
Remove use of minimumValueForLength in HTMLAreaElement::getRegion

While the 'coords' attribute on HTMLAreaElement is stored as a
Vector<Length>, the Lengths will all be of the type 'Fixed'. This means
that the only effect of minimumValueForLength() will be to round-trip
through LayoutUnit - resulting in a clamp to the allowed range of
LayoutUnit. Replace the uses of minimumValueForLength() with a new
function (clampCoordinate) that only does this clamping.

BUG=578114
==========

to

==========
Remove use of minimumValueForLength in HTMLAreaElement::getRegion

While the 'coords' attribute on HTMLAreaElement is stored as a
Vector<Length>, the Lengths will all be of the type 'Fixed'. This means
that the only effect of minimumValueForLength() will be to round-trip
through LayoutUnit - resulting in a clamp to the allowed range of
LayoutUnit. Replace the uses of minimumValueForLength() with a new
function (clampCoordinate) that only does this clamping.

No functional changes.

BUG=578114
==========

[fs, 2016-01-22 14:41:43]

On 2016/01/22 at 10:15:38, fs wrote:
> On 2016/01/21 at 23:04:54, tkent wrote:
...
> > According to crbug.com/578114, now web-platform-tests has a test for this,
right?  So, we should update imported web-platform-tests first.
> 
> This is just a cleanup in preparation for fixing the real issues there. I'll
send a CL to "import" the new tests. (I say "import" because crbug.com/498120
blocks proper import. Will file a bug to block on that one.)

Uploaded the CL with the tests now: https://codereview.chromium.org/1618373002
(still no functional changes in this CL though =))

[tkent, 2016-01-25 01:46:19]

lgtm.

I'm sorry that I jumped to a wrong conclusion!

[tkent, 2016-01-25 01:46:33]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-01-25 01:46:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619793002/1

[commit-bot: I haz the power, 2016-01-25 04:13:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-25 04:14:07]

Description was changed from

==========
Remove use of minimumValueForLength in HTMLAreaElement::getRegion

While the 'coords' attribute on HTMLAreaElement is stored as a
Vector<Length>, the Lengths will all be of the type 'Fixed'. This means
that the only effect of minimumValueForLength() will be to round-trip
through LayoutUnit - resulting in a clamp to the allowed range of
LayoutUnit. Replace the uses of minimumValueForLength() with a new
function (clampCoordinate) that only does this clamping.

No functional changes.

BUG=578114
==========

to

==========
Remove use of minimumValueForLength in HTMLAreaElement::getRegion

While the 'coords' attribute on HTMLAreaElement is stored as a
Vector<Length>, the Lengths will all be of the type 'Fixed'. This means
that the only effect of minimumValueForLength() will be to round-trip
through LayoutUnit - resulting in a clamp to the allowed range of
LayoutUnit. Replace the uses of minimumValueForLength() with a new
function (clampCoordinate) that only does this clamping.

No functional changes.

BUG=578114

Committed: https://crrev.com/41260e42ad6324ca4faa72576757244bf4596218
Cr-Commit-Position: refs/heads/master@{#371184}
==========

[commit-bot: I haz the power, 2016-01-25 04:14:08]

Patchset 1 (id:??) landed as
https://crrev.com/41260e42ad6324ca4faa72576757244bf4596218
Cr-Commit-Position: refs/heads/master@{#371184}