Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1618373002: Add tests for HTMLAreaElement coords/shape and processing model (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for HTMLAreaElement coords/shape and processing model This makes local copies of: html/semantics/embedded-content/the-area-element/area-coords.html html/semantics/embedded-content/the-area-element/area-processing.html html/semantics/embedded-content/the-area-element/area-shape.html html/semantics/embedded-content/the-area-element/support/hit-test.js in fast/html/ and adjust them so that they can run correctly in the test runner. The adjustment amounts to referencing a different image than the original, and doing so using a relative path, and putting hit-test.js in the local resources/ directory in fast/html. BUG=578125, 578114, 498120 Committed: https://crrev.com/7abb4d0b65c8b62e3ab27a387dc49c4bdae16f31 Cr-Commit-Position: refs/heads/master@{#371246}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment in W3CImportExpectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/area-coords.html View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/area-coords-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/area-processing.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/area-processing-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/area-shape.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/area-shape-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/resources/hit-test.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fs
4 years, 11 months ago (2016-01-22 15:43:44 UTC) #2
tkent
lgtm https://codereview.chromium.org/1618373002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1618373002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode303 third_party/WebKit/LayoutTests/W3CImportExpectations:303: imported/web-platform-tests/html/semantics/embedded-content/the-area-element [ Skip ] Please add a comment ...
4 years, 11 months ago (2016-01-25 01:48:00 UTC) #3
fs
https://codereview.chromium.org/1618373002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1618373002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode303 third_party/WebKit/LayoutTests/W3CImportExpectations:303: imported/web-platform-tests/html/semantics/embedded-content/the-area-element [ Skip ] On 2016/01/25 at 01:48:00, tkent ...
4 years, 11 months ago (2016-01-25 09:29:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618373002/20001
4 years, 11 months ago (2016-01-25 10:12:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/163712)
4 years, 11 months ago (2016-01-25 12:19:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618373002/20001
4 years, 11 months ago (2016-01-25 15:34:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 15:39:54 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 15:42:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7abb4d0b65c8b62e3ab27a387dc49c4bdae16f31
Cr-Commit-Position: refs/heads/master@{#371246}

Powered by Google App Engine
This is Rietveld 408576698