Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1619453002: Revert of Check if internal_format is valid for GenerateMipmap(). (Closed)

Created:
4 years, 11 months ago by alancutter (OOO until 2018)
Modified:
4 years, 11 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, Ken Russell (switch to Gerrit), bajones, vmiura, qiankun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check if internal_format is valid for GenerateMipmap(). (patchset #2 id:20001 of https://codereview.chromium.org/1605323004/ ) Reason for revert: Broke the following webkit_tests on all platforms: virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-pixel.html Original issue's description: > Check if internal_format is valid for GenerateMipmap(). > > BUG=429053 > TEST=gpu_unittests,webgl2_conformance > R=piman@chromium.org > > Committed: https://crrev.com/33040da405658793aa7b248e8ea6e292fad46193 > Cr-Commit-Position: refs/heads/master@{#370562} TBR=piman@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429053 Committed: https://crrev.com/2b96134dc68c4f207285991476e6c4b96bd07663 Cr-Commit-Position: refs/heads/master@{#370614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -229 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -68 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +0 lines, -76 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 3 chunks +0 lines, -34 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 5 chunks +16 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 11 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
alancutter (OOO until 2018)
Created Revert of Check if internal_format is valid for GenerateMipmap().
4 years, 11 months ago (2016-01-21 04:04:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619453002/1
4 years, 11 months ago (2016-01-21 04:05:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 04:07:29 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 04:09:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b96134dc68c4f207285991476e6c4b96bd07663
Cr-Commit-Position: refs/heads/master@{#370614}

Powered by Google App Engine
This is Rietveld 408576698