gpu/command_buffer/service/texture_manager.h - Issue 1619453002: Revert of Check if internal_format is valid for GenerateMipmap().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_manager.h

Issue 1619453002: Revert of Check if internal_format is valid for GenerateMipmap(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/texture_manager.h

diff --git a/gpu/command_buffer/service/texture_manager.h b/gpu/command_buffer/service/texture_manager.h

index 723f0fb4fc34451021beee4f376262b028160433..5a07d99ee79ce48e3e25029797bbca5c3a1b9ade 100644

--- a/gpu/command_buffer/service/texture_manager.h

+++ b/gpu/command_buffer/service/texture_manager.h

@@ -344,7 +344,7 @@

const FeatureInfo* feature_info, GLenum pname, GLfloat param);

// Makes each of the mip levels as though they were generated.

- void MarkMipmapsGenerated(const FeatureInfo* feature_info);

+ bool MarkMipmapsGenerated(const FeatureInfo* feature_info);

bool NeedsMips() const {

return min_filter_ != GL_NEAREST && min_filter_ != GL_LINEAR;

@@ -756,7 +756,8 @@

TextureRef* ref, GLenum pname, GLfloat param);

// Makes each of the mip levels as though they were generated.

- void MarkMipmapsGenerated(TextureRef* ref);

+ // Returns false if that's not allowed for the given texture.

+ bool MarkMipmapsGenerated(TextureRef* ref);

// Clears any uncleared renderable levels.

bool ClearRenderableLevels(GLES2Decoder* decoder, TextureRef* ref);