Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1618313003: Set cc_flags for cmake build on Mac (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@swiz
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +16 lines, -0 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
bsalomon
Not intended to land. Do you guys have some tricks for making CLion/cmake builds work ...
4 years, 11 months ago (2016-01-22 16:03:54 UTC) #3
mtklein
https://codereview.chromium.org/1618313003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/1618313003/diff/1/gyp/common_conditions.gypi#newcode533 gyp/common_conditions.gypi:533: 'WARNING_CFLAGS': [ One trick I've often considered is that ...
4 years, 11 months ago (2016-01-22 16:14:18 UTC) #4
mtklein
On 2016/01/22 16:03:54, bsalomon wrote: > Not intended to land. > > Do you guys ...
4 years, 11 months ago (2016-01-22 16:14:55 UTC) #5
bsalomon
4 years, 11 months ago (2016-01-22 16:25:34 UTC) #6
https://codereview.chromium.org/1618313003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1618313003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:533: 'WARNING_CFLAGS': [
On 2016/01/22 16:14:18, mtklein wrote:
> One trick I've often considered is that any cflags can go in here, not just
> warning flags.
> 
> We could pile most things into a variable that we then expand into
> WARNING_CFLAGS and 'cflags', removing most of these CLANG_ and GCC_ one-off
> settings for the version in comments on the right.
> 
> That doesn't help C++-specific flags, like -std=c++11 and -fnortti. 
> WARNING_CFLAGS is used for C and C++ code alike.

With Herb's change to gyp --std=c++11 is applied to all the cmake C++ compiles,
but these other flags are not (WARNING_CFLAGS and CLANG_/GCC_ settings alike).
So something like that seems like a step forward.

Powered by Google App Engine
This is Rietveld 408576698