Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: gyp/common_conditions.gypi

Issue 1618313003: Set cc_flags for cmake build on Mac (Closed) Base URL: https://skia.googlesource.com/skia.git@swiz
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 8221c94680a645a68b91927d83276065b042fb69..8d1e2655b6c7a0406692d5b3d00c501094fa29ee 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -519,6 +519,7 @@
'LIBRARY_SEARCH_PATHS': [ '/usr/lib -fsanitize=<(skia_sanitizer)'],
}],
],
+ # Keep these in sync with cflags_cc below
'CLANG_CXX_LIBRARY': 'libc++',
'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions
@@ -539,6 +540,21 @@
'-Wno-unused-parameter',
],
},
+ # Keep these in sync with xcode settings above
+ 'cflags_cc': [
+ '-std=c++11',
+ '-fno-rtti',
+ '-fno-threadsafe-statics',
+ '-mssse3',
+ '-fvisibility=hidden',
+ '-fvisibility-inlines-hidden',
+ '-Wall',
+ '-Wextra',
+ '-Winit-self',
+ '-Wpointer-arith',
+ '-Wsign-compare',
+ '-Wno-unused-parameter',
+ ],
},
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698