Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1617433002: Make swizzling in read/write pixel copy code more generic (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : fix mesa code path #

Total comments: 2

Patch Set 4 : Address comment #

Patch Set 5 : Fix loop in config conversion test create #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -90 lines) Patch
M include/gpu/GrContext.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 9 chunks +10 lines, -13 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 3 chunks +16 lines, -12 lines 0 comments Download
M src/gpu/GrSwizzle.h View 1 2 chunks +17 lines, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 4 11 chunks +41 lines, -43 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 5 chunks +19 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
bsalomon
4 years, 11 months ago (2016-01-21 14:28:35 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/1617433002/diff/80001/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.chromium.org/1617433002/diff/80001/src/gpu/GrGpu.h#newcode161 src/gpu/GrGpu.h:161: GrSwizzle fSwizzle; read -> used to read ?
4 years, 11 months ago (2016-01-21 17:38:55 UTC) #6
bsalomon
https://codereview.chromium.org/1617433002/diff/80001/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.chromium.org/1617433002/diff/80001/src/gpu/GrGpu.h#newcode161 src/gpu/GrGpu.h:161: GrSwizzle fSwizzle; On 2016/01/21 17:38:55, robertphillips wrote: > read ...
4 years, 11 months ago (2016-01-21 20:02:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617433002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617433002/100001
4 years, 11 months ago (2016-01-21 20:02:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_TIMED_OUT, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/481)
4 years, 11 months ago (2016-01-22 05:32:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617433002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617433002/120001
4 years, 11 months ago (2016-01-22 15:05:38 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 15:17:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://skia.googlesource.com/skia/+/6c9cd55f00beeba3ded3f28bcbdd6ef030c4dac7

Powered by Google App Engine
This is Rietveld 408576698