separate arrays for color and coverage effects.

separate arrays for color and coverage effects.

R=robertphillips@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9465

[bsalomon, 2013-06-06 19:21:07]

Removes some more kNumStages.

[bsalomon, 2013-06-06 19:22:24]

Removes some more kNumStages

[robertphillips, 2013-06-06 19:38:15]

lgtm + a suggestion & a question

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgram.cpp#ne...
src/gpu/gl/GrGLProgram.cpp:760: 
sub-routine for these two?

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgramDesc.cpp
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgramDesc.cp...
src/gpu/gl/GrGLProgramDesc.cpp:227: if (separateCoverageFromColor) {
Do we really need fColorEffectCnt and fCoverageEffectCnt anymore?

[bsalomon, 2013-06-06 20:07:40]

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgram.cpp#ne...
src/gpu/gl/GrGLProgram.cpp:760: 
On 2013/06/06 19:38:15, robertphillips wrote:
> sub-routine for these two?

yeah, will do

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgramDesc.cpp
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/16180006/diff/1/src/gpu/gl/GrGLProgramDesc.cp...
src/gpu/gl/GrGLProgramDesc.cpp:227: if (separateCoverageFromColor) {
On 2013/06/06 19:38:15, robertphillips wrote:
> Do we really need fColorEffectCnt and fCoverageEffectCnt anymore?

Yeah, these are used as the bounds of the arrays of effects we pass around.

[bsalomon, 2013-06-06 20:29:17]

Committed patchset #2 manually as r9465 (presubmit successful).