experiment: float color components

experiment: float color components

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617813002

Committed: https://skia.googlesource.com/skia/+/353c148d8e8c9031daca34c6f9d6bcc6f08706c7

[reed1, 2016-01-21 15:44:14]

Description was changed from

==========
experiment: float color components

BUG=skia:
==========

to

==========
experiment: float color components

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-21 15:44:57]

reed@google.com changed reviewers:
+ fmalita@chromium.org, mtklein@google.com

[reed1, 2016-01-21 15:44:58]

WIP -- just exploring ideas

[mtklein, 2016-01-21 17:52:36]

lgtm

https://codereview.chromium.org/1617813002/diff/1/include/core/SkColor.h
File include/core/SkColor.h (right):

https://codereview.chromium.org/1617813002/diff/1/include/core/SkColor.h#newc...
include/core/SkColor.h:166: float fVec[4];
To be super-sweet,

struct SK_ATTRIBUTE(aligned(16)) SkPM4f {
   ...
};

This will make sure the floats are aligned when you put them on the stack.
(This is often guaranteed anyway, depending on the OS + CPU architecture.)

[mtklein, 2016-01-21 19:28:30]

https://codereview.chromium.org/1617813002/diff/40001/src/core/SkColor.cpp
File src/core/SkColor.cpp (right):

https://codereview.chromium.org/1617813002/diff/40001/src/core/SkColor.cpp#ne...
src/core/SkColor.cpp:106: SkColor4f SkColor4f::Normalize(float a, float r, float
g, float b) {
Pin?  (Also, SkNx this?)

https://codereview.chromium.org/1617813002/diff/40001/src/core/SkColor.cpp#ne...
src/core/SkColor.cpp:110: SkColor4f SkColor4f::FromColor(SkColor c) {
Something like,

#include "SkNx.h"
 SkColor4f SkColor4f::FromColor(SkColor c) {
     auto f4 = SkNx_cast<float>(Sk4b::Load((const uint8_t*)&c));

     // b,g,r,a -> a,r,g,b
     f4 = SkNx_shuffle<3,2,1,0>(f4);
     f4 = f4 * Sk4f(1.0f/255);

     SkColor4f r;
     f4.store(&r.fA);
     return r;
 }

[reed1, 2016-01-21 21:22:09]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 21:22:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617813002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617813002/60001

[reed1, 2016-01-21 21:22:33]

reed@google.com changed reviewers:
+ herb@google.com

[commit-bot: I haz the power, 2016-01-21 21:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 21:23:26]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[reed1, 2016-01-21 22:00:08]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-21 22:00:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1617813002/#ps80001
(title: "fix win warning")

[commit-bot: I haz the power, 2016-01-21 22:00:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617813002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617813002/80001

[commit-bot: I haz the power, 2016-01-21 22:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 22:03:03]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[reed1, 2016-01-21 22:08:13]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-21 22:08:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1617813002/#ps100001
(title: "fix 'nother warning")

[commit-bot: I haz the power, 2016-01-21 22:08:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1617813002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1617813002/100001

[commit-bot: I haz the power, 2016-01-21 23:29:12]

Description was changed from

==========
experiment: float color components

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
experiment: float color components

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/353c148d8e8c9031daca34c6f9d6bcc6f08706c7
==========

[commit-bot: I haz the power, 2016-01-21 23:29:13]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/353c148d8e8c9031daca34c6f9d6bcc6f08706c7

[reed1, 2016-01-22 08:04:21]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1623453002/ by reed@google.com.

The reason for reverting is: broke some colormatrix tests.