third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h - Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix oilpan compilation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp ('k') | third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h

diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h

index c54e2f1849b92a6fe28c03e3c3f62be8b558b1c7..3fd6ff12da7584b29c94375f2553a014cc18b921 100644

--- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h

+++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h

@@ -63,7 +63,7 @@ public:

virtual ~PlatformSpeechSynthesizer();

- const HeapVector<Member<PlatformSpeechSynthesisVoice>>& voiceList() const { return m_voiceList; }

+ const Vector<RefPtr<PlatformSpeechSynthesisVoice>>& voiceList() const { return m_voiceList; }

virtual void speak(PlatformSpeechSynthesisUtterance*);

virtual void pause();

virtual void resume();

@@ -71,7 +71,7 @@ public:

PlatformSpeechSynthesizerClient* client() const { return m_speechSynthesizerClient; }

- void setVoiceList(HeapVector<Member<PlatformSpeechSynthesisVoice>>&);

+ void setVoiceList(Vector<RefPtr<PlatformSpeechSynthesisVoice>>&);

// Eager finalization is required to promptly release the owned WebSpeechSynthesizer.

@@ -89,7 +89,7 @@ protected:

virtual void initializeVoiceList();

- HeapVector<Member<PlatformSpeechSynthesisVoice>> m_voiceList;

+ Vector<RefPtr<PlatformSpeechSynthesisVoice>> m_voiceList;

private:

Member<PlatformSpeechSynthesizerClient> m_speechSynthesizerClient;